chore(PLATFORM-10076): migrate PageForms #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wladekb
reviewed
Feb 12, 2025
| @@ -1038,7 +1040,7 @@ function formHTML( | |||
| $brackets_end_loc = strpos( $section, "}}}", $brackets_loc ); | |||
| // For cases with more than 3 ending brackets, | |||
| // take the last 3 ones as the tag end. | |||
| while ( $section[$brackets_end_loc + 3] == "}" ) { | |||
| while ( isset( $section[$brackets_end_loc + 3] ) && $section[$brackets_end_loc + 3] == "}" ) { | |||
There was a problem hiding this comment.
while ( ( $section[$brackets_end_loc + 3] ?? null ) == "}" ) {
might be more readable
There was a problem hiding this comment.
I don't have a strong opinion, but I would stick to isset in this case as it is more explicit - checking whether element exist
Using ?? null hides this intention - we are comparing null == "}" instead when element is not set
PLATFORM-10860: Fix invalid arguments in ArticleUpdateBeforeRedirect hook call
chore(PLATFORM-10999): update CargoUtils::getDB to use DB_REPLICA
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.