Adds rescue block in StudentGreetingChecker's talk_page_blank?
#6192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…_api `get_page_content` raises a `PageFetchError` with status `429` + Stores the `response.status` as an instance variable in PageFetchError and make it accessible
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
talk_page_blank?method to return true if wiki_apiget_page_contentraises aPageFetchErrorwith status429response.statusas an instance variable in PageFetchError and make it accessibleScreenshots
Before adding rescue block:
After adding rescue but before adding status as an instance variable in the
PageFetchErrordefinition:After:
