Fix: Issue with high_quality_article_monitor_spec

[Formasitchijoh]

What this PR does

This PR addresses the recent CI build failure and improves upon the previous fix, which was inefficient.

Issue with the Previous Fix:

• The travel_to helper method was only applied when creating the course, meaning that subsequent interactions in the test used the current system time instead of the intended past time. This caused failures when the test logic compared dates, as the current time was beyond the course end date.

• The previous fix also relied on Date.new, which does not account for time zones, making it ineffective for this scenario.

Improvements in This Fix:

• Replaced Date.new with Time.zone.local which is Rails-specific and handle time zones .
• Moved travel_to into the before block to ensure that all test interactions occur within the correct time frame.
• Ensured proper reset to the system time after the test completes using travel_back method .

This fix travels to a time between the start and end date to ensures that all test blocks operate within the intended date context, leading to more reliable and consistent test execution.

A detail explanation of how these helpers work is found here

@gabina , your assumption about how travel_to was used previously is correct. Thank you for your input

[gabina]

Is this really necessary? Or is it just a good practice?

According to the travel_to docs:

Changes current time to the given time by stubbing Time.now, Time.new, Date.today, and DateTime.now to return the time or date passed into this method. The stubs are automatically removed at the end of the test.

So I understand that it is not strictly necessary but perhaps it is considered a good practice?

[Formasitchijoh]

Yeah you are right, just wanted to make sure the time is reset back