[Data rearchitecture] Fix minor bug in RevisionStatTimeslice #6186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…is set to 7 days. If the course start is less that one week ago, we don't want to try to retrieve a timeslice for 7 days ago because that timeslice won't exist. Because of that, now we fix the start period for the timeframe as the max between course start or 7 days ago.
gabina
merged commit 08b4e0d
into
WikiEducationFoundation:data-rearchitecture-for-dashboard
1 check passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
This PR fixes a bug in
RevisionStatTimeslice. Since the TIMEFRAME is set to 7 days, therecent_revisions_for_courses_usermethod fails if a course started yesterday because it attempts to retrieve a course wiki timeslice from seven days ago, which doesn't exist.This fix ensures that the start period never references a date earlier than the course start date.
Open questions and concerns
< anything you learned that you want to share, or questions you're wondering about related to this PR >