[Data rearchitecture] Fix bug in UpdateTimeslicesCourseDate to support drastic course dates changes #6185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… course dates. Now when the previous course period and the current one have no overlap, delete the existing timeslices and generate new ones. Add basic specs for it.
gabina
merged commit 42a3448
into
WikiEducationFoundation:data-rearchitecture-for-dashboard
1 check passed
gabina
deleted the
data-rearchitecture-support-drastic-course-dates-changes
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
This PR adds a new
update_timeslices_if_drastic_changemethod to handle cases in which the previous course period and the current one have no overlap. In those cases, we delete the timeslices and create them again.Open questions and concerns
< anything you learned that you want to share, or questions you're wondering about related to this PR >