[Data rearchitecture] Sync with master #6178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…fo UI + Defines functions to get stats and queue info from Sidekiq
…tats: - Adds route for UI to config - Controller fetches metrics from service class - Service class renamed and fetches data and manipulates it as needed - View created using haml template to display information - Adds descriptions of queues / metrics in locales en.yml
… Updates format_time method to correctly calculate sub_unit_value in all cases
…ency thresholds + Added more tests for the GetSystemMetrics service
…ikiEduDashboard into @update/kt-paperclip
…tudentProgramEndpoint Removed unneeded fields from new endpoint
…actorReactClassComponentsStream Converted form_panel.jsx from class to functional component
…actorReactClassComponentsStream2 Refactored : meetings.jsx from class to functional component
…fix/assigned-article-spec Fix: removed check for loading feedback text in assigned article spec
- Adds optional chaining operators
- Introduces a helper function to check table validity as an extension of the `document.querySelectorAll('#users table').length` check. It now checks that:
- at least one table is present and
- the table(s) has a body and rows
…style')` in `list.jsx` by ensuring `floatingHeaderRow` exists before accessing its `style` property.
- Prevents: `TypeError: Cannot read properties of null (reading 'cloneNode')` in `article_viewer.js` by ensuring `.user-legend-wrap` exists before attempting to clone it.
- Prevents: `Error: Objects are not valid as a React child (found: object with keys {error}). If you meant to render a collection of children, use an array instead.` in `notifications.js` by ensuring `notification.message` is always a string when it is passed to the React component for rendering.
…logic - Updated DYKNominationMonitor, GANominationMonitor, and ArticlesForDeletionMonitor specs - Removed unnecessary revision creation and ensured tests work without revision_id - Added tests to verify user_id is correctly assigned from articles_course.user_ids.first
…fix/capybara-screenshot-name Fix: removed special characters from capybara screenshot name
User:Toti&bubu was unable to mark a sandbox exercise as complete, because TrainingModulesUsers#eligibile_for_completion was looking for the url-encoded version of the expected sandbox page and failing to find it. This is a quick fix that works for the affected user, but there might be other username edge cases where this will fail. It would be useful to add tests for various other characters as part of usernames.
…ct when `data.responseText` is invalid and `notification.message` falls back to the whole `data` object
…typeerror-occurences Fix: Prevent occurrences of `TypeError`s
…fix/assign_article_account_requests_specs Fix: Failure in account_request and assigned_article spec
…lment_controller_spec` to explicitly mock `get_page_content` and return a valid response + Updates `wiki_api_spec` error handling test expectations
…les-wikiapi-unexpected-responses Raises a custom `PageFetchError` when the `response.status `is not 200 or 404
…ltip_campaign_dashboard feat: Add tooltip for enable account requests button in the campaign dashboard
This is our first try at adding translations to the yml-based Wiki Education training modules, ahead of offering a Spanish-language Wikipedia Scholars & Scientists course.
For the wiki-based translations, we use symbols as keys for individual fields of translated content. This makes ensures the yml-based module and slide translations have the same key format, so that they will actually render.
… title and namespace except for the most recently created. This fixes a previous bug whereby the newest article was deleted, and the one kept was the oldest, due to the default order for ActiveRecord.
… discretionary sactions monitor spec
…fix/high-article-alert Fix: issue with course_assignment returning an empty object
…lete-the-newest-duplica-article `DuplicateArticleDeleter`: fix existing bug to keep the most recently created article instead of the oldest one
…re-sync-with-master
gabina
merged commit d8af364
into
WikiEducationFoundation:data-rearchitecture-for-dashboard
1 check passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Periodic sync with master