Fix: #6087 Display specific error message for course slug collision (revision) #6168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ragesoss
reviewed
Feb 6, 2025
app/assets/javascripts/utils/api.js
Outdated
| @@ -321,6 +321,10 @@ const API = { | |||
| }); | |||
|
|
|||
| if (!response.ok) { | |||
| if (response.status === 422 || response.status === 400) { | |||
There was a problem hiding this comment.
Rather than special handling in JS, this should follow the pattern used elsewhere in the app where the message from the JSON error response shown, rather than a message that is part of frontend code.
See assignments_controller.rb for some examples of this pattern, or the PR that fixed another instance of this sort of issue: #1760
There was a problem hiding this comment.
@ragesoss I've made the changes you can check them. Now, the backend dynamically returns JSON error responses in all supported languages based on the selected language. I’ve also updated the screenshots for your review. Let me know if you have any feedback!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
(Revision)
Fixes #6087
This PR addresses the issue where a generic "Internal Server Error" message was displayed when a user attempted to change a course slug to one that already existed.
Screenshots
Before:
This is an error occurring not showing proper message only showing Internal Server Error
Course titles can be identical for different organizations or institutions, but must be unique within the same organization or institution. This is because course titles are used to dynamically generate URLs (slugs), and duplicate titles within the same organization would create URL conflicts.
look: below
After:
Showing proper message
Updated