Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Data rearchitecture] Clean models #6162

Conversation

gabina
Copy link
Member

@gabina gabina commented Jan 28, 2025

What this PR does

This PR cleans up model migrations:

  • Delete unused last_mw_rev_id, upload_count, uploads_in_use_count and upload_usages_count fields from CourseWikiTimeslice.
  • Delete unused last_mw_rev_id and total_uploads fields from CourseUserWikiTimeslice.
  • Delete unused last_mw_rev_id field from ArticleCourseTimeslice.

In addition, it reverts the changes in #6048 for adding a new revision_count field to ArticlesCourses. Since we don't create the complete universe of article course timeslices anymore (see #6069), it's reasonable to compute revision_count for UpdateWikiNamespaceStatsTimeslice based on article course timeslices.

Screenshots

Before:
< add a screenshot of the UI before your change >

After:
< add a screenshot of the UI after your change >

Open questions and concerns

< anything you learned that you want to share, or questions you're wondering about related to this PR >

@gabina gabina force-pushed the data-rearchitecture-clean-models branch from 5a469bf to 38525da Compare January 29, 2025 01:02
@gabina gabina marked this pull request as ready for review January 31, 2025 17:14
@gabina gabina changed the title [WIP] [Data rearchitecture] Clean models [Data rearchitecture] Clean models Jan 31, 2025
@gabina gabina merged commit e817b61 into WikiEducationFoundation:data-rearchitecture-for-dashboard Jan 31, 2025
1 check passed
@gabina gabina deleted the data-rearchitecture-clean-models branch January 31, 2025 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant