Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Data rearchitecture] Improve logs during course updates #6149

Prev Previous commit
Fix specs
gabina committed Jan 22, 2025
commit 51dd4bbb732e3b1c5c2518eaab809bc4992809d6
19 changes: 9 additions & 10 deletions spec/services/update_course_wiki_timeslices_spec.rb
Original file line number Diff line number Diff line change
@@ -14,11 +14,19 @@
let(:flags) { nil }
let(:user) { create(:user, username: 'Ragesoss') }

before do
stub_wiki_validation
travel_to Date.new(2018, 12, 1)
course.campaigns << Campaign.first
course.wikis << Wiki.get_or_create(language: nil, project: 'wikidata')
JoinCourse.new(course:, user:, role: 0)
end

context 'when debugging is not enabled' do
it 'posts no Sentry logs' do
expect(Sentry).not_to receive(:capture_message)
processed, reprocessed = subject
expect(processed).to eq(7)
expect(processed).to eq(14)
expect(reprocessed).to eq(0)
end
end
@@ -33,15 +41,6 @@
end

context 'when there are revisions' do
before do
stub_wiki_validation
travel_to Date.new(2018, 12, 1)
course.campaigns << Campaign.first
# Create course wiki timeslices manually for wikidata
course.wikis << Wiki.get_or_create(language: nil, project: 'wikidata')
JoinCourse.new(course:, user:, role: 0)
end

it 'updates article course timeslices caches' do
VCR.use_cassette 'course_update' do
subject

Unchanged files with check annotations Beta

export const TitleOpener = ({ showArticle, showButtonClass, showButtonLabel, title }) => (
<div className={`tooltip-trigger ${showButtonClass || ''}`}>
<button style={{ textAlign: 'left' }} onClick={showArticle} aria-describedby="icon-article-viewer-desc">{title}</button>
<p id="icon-article-viewer-desc">Open Article Viewer</p>

Check warning on line 7 in app/assets/javascripts/components/common/ArticleViewer/components/TitleOpener.jsx

GitHub Actions / build

Use I18n over string literals for localization: <p id="icon-article-viewer-desc">Open Article Viewer</p>
<div className="tooltip tooltip-title dark large">
<p>{showButtonLabel()}</p>
</div>

Check warning on line 10 in app/assets/javascripts/components/common/AssignmentLinks/AllPeerReviewLinks.jsx

GitHub Actions / build

Use I18n over string literals for localization: <span key="title">Reviews: </span>
let requestedAccountsLink;
if (!Features.wikiEd) {
const massEnrollmentUrl = `/mass_enrollment/${course.slug}`;
massEnrollmentLink = <p><a href={massEnrollmentUrl}>Add multiple users at once.</a></p>;

Check warning on line 132 in app/assets/javascripts/components/common/enroll_button.jsx

GitHub Actions / build

Use I18n over string literals for localization: <a href={massEnrollmentUrl}>Add multiple users at once.</a>
}
if (!Features.wikiEd) {
const requestedAccountsUrl = `/requested_accounts/${course.slug}`;
let button;
if (isVisible) {
button = <button onClick={hide} className="button dark small">Okay</button>;

Check warning on line 41 in app/assets/javascripts/components/common/final_article_checklist.jsx

GitHub Actions / build

Use I18n over string literals for localization: <button onClick={hide} className="button dark small">Okay</button>
} else {
button = <a onClick={show} className="button dark small">Quality checklist</a>;

Check warning on line 43 in app/assets/javascripts/components/common/final_article_checklist.jsx

GitHub Actions / build

Use I18n over string literals for localization: <a onClick={show} className="button dark small">Quality checklist</a>
}
let modal;
} else {
modal = (
<div ref={ref} className="article-viewer my-assignment-checklist">
<h2>Final review checklist</h2>

Check warning on line 52 in app/assets/javascripts/components/common/final_article_checklist.jsx

GitHub Actions / build

Use I18n over string literals for localization: <h2>Final review checklist</h2>
<p>
As you polish up your completed article, review each of these items and fix any problems you find.
</p>
const wikipediaHelpUser = this.wikipediaHelpUser();
wikipediaHelpButton = (
<span className="contact-wikipedia-help" key={`${wikipediaHelpUser.username}-wikipedia-help`}>
<a href="#" className="wikipedia-help-link button dark small stacked" onClick={e => this.updateTargetUser(wikipediaHelpUser, e)}>question about editing Wikipedia</a>

Check warning on line 114 in app/assets/javascripts/components/common/get_help_button.jsx

GitHub Actions / build

Use I18n over string literals for localization: <a href="#" className="wikipedia-help-link button dark small stacked" onClick={e => this.updateTargetUser(wikipediaHelpUser, e)}>question about editing Wikipedia</a>
<br />
</span>
);
const programHelpUser = this.programHelpUser();
programHelpButton = (
<span className="contact-program-help" key={`${programHelpUser.username}-program-help`}>
<a href="#" className="program-help-link button dark stacked small" onClick={e => this.updateTargetUser(programHelpUser, e)}>question about Wiki Ed or your assignment</a>

Check warning on line 124 in app/assets/javascripts/components/common/get_help_button.jsx

GitHub Actions / build

Use I18n over string literals for localization: <a href="#" className="program-help-link button dark stacked small" onClick={e => this.updateTargetUser(programHelpUser, e)}>question about Wiki Ed or your assignment</a>
<br />
</span>
);
const dashboardHelpUser = this.dashboardHelpUser();
dashboardHelpButton = (
<span className="contact-dashboard-help" key={`${dashboardHelpUser.username}-dashboard-help`}>
<a href="#" className="dashboard-help-link button dark stacked small" onClick={e => this.updateTargetUser(dashboardHelpUser, e)}>question about the dashboard</a>

Check warning on line 134 in app/assets/javascripts/components/common/get_help_button.jsx

GitHub Actions / build

Use I18n over string literals for localization: <a href="#" className="dashboard-help-link button dark stacked small" onClick={e => this.updateTargetUser(dashboardHelpUser, e)}>question about the dashboard</a>
<br />
</span>
);
let button;
if (isVisible) {
button = <button onClick={hide} className="button dark small">Okay</button>;

Check warning on line 20 in app/assets/javascripts/components/common/mainspace_checklist.jsx

GitHub Actions / build

Use I18n over string literals for localization: <button onClick={hide} className="button dark small">Okay</button>
} else {
button = <a onClick={show} className="button dark small">Quality checklist</a>;
}