[Data rearchitecture] sync with master #6119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing up using Docker
…`'s `user_data` is `nil` and tests to confirm expected behaviour
…ate_mysql_hosts [FIX]: Database Connection Issue by Hostname Resolution During Setup Using Docker
Wiki Experts discussed this and decided that 1000 was too high of a minimum. We'll try 200 and see if that feels right.
…nil-user-data-no-method-error FIX: Add guard statements to prevent `NoMethodError`s when `get_user_info's `user_data` is `nil`
…update_troubleshooting Sync troubleshooting.md with setup.md
…fix/multiwiki_assignment_spec fix: marked flaky test in multiwiki_assignment_spec as pending
- When answer to trigger question changes, correctly remove conditional follow-up question by updating Slick slider's internal state before DOM manipulation. Restores intended survey flow behavior - Removed unnecessary test code that was no longer required because of the current fix.
…guard_clause Fix Rubocop Style/GuardClause Violations
…t don't join a course
…unter, and revision_score_api
…nt in update_course_stats_spec
…nditional-survey-questions-handling Fix Conditional Question Display State Issues in Surveys
…ock-flaky-tests Fix: Mock flaky tests
I think I missed these files when I was recently removing features that relied on the Revisions table.
…facts for debugging
- Added a condition to exclude `survey-admin.js` from being loaded during preview mode. - Updated `surveys.html.haml` to check for the "preview" parameter in the request. - This fix ensures the preview mode renders the correct content without interference from admin-specific scripts.
PagePileApi will update the wiki for a Category record, if it doesn't match what the API returns. To avoid hash collisions on Category records, we need to make sure we only have one record per pileid.
…orkflow-artifact Feature: Extended workflow to save screenshot of failed Capybara tests
…efactor-multiwiki-assignment-spec Fix: Added rapid: false parameter to textarea set method
…estion-group-preview-bug Fix "Preview Question Group" button rendering an empty page when accessing through Question Groups tab
- Avoid direct mutation of `course.revisions` by creating a new object with updated revisions. - Ensures compliance with Redux's immutability rules to avoid errors during state updates.
- Updated the variable name to better reflect its role in controlling both mutation and serializability checks. - Improves code clarity and maintainability by using a more descriptive and accurate name.
… some courses: - Uses `CGI.unescape` to decode url encoded string to their original formats if applicable thus solving cause of 500 error - Improves error handling in js actions and reducers to not result in TypeErrors when a 500 error (or any other error) occurs
…allow-decoding-of-filenames Fix: `uploads.json` endpoint returns `500 internal server error` for some courses#6046
…dux-state-mutation Fix: Prevent state mutation in fetchRevisionsPromise function
…redux-safety-checks Chore: Refactor variable name for Redux safety checks
…re-sync-with-master
gabina
merged commit a5fe9ce
into
WikiEducationFoundation:data-rearchitecture-for-dashboard
1 check failed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
Periodic sync with master