Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Outreachy Round 27] Use reference-counter html endpoint #5676

Conversation

gabina
Copy link
Member

@gabina gabina commented Feb 26, 2024

What this PR does

This PR is part of the "Improve how Wiki Education Dashboard counts references added" project (read issue #5547).

It updates the Toolforge endpoint used in ReferenceCounterApi class to count references from html instead of wikitext. Read more context about that in phabricator task T352177.

@gabina gabina marked this pull request as draft February 26, 2024 22:27
@gabina gabina force-pushed the 5547-outreachy-round-27-use-new-html-toolforge-endpoint branch from 3b5de27 to 16db18b Compare April 8, 2024 20:49
Comment on lines +41 to +42
"rest-permission-denied-revision - User doesn't have access to the requested " \
'revision (708326238).'
Copy link
Member Author

@gabina gabina Apr 8, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the toolforge reference-counter HTML endpoint, we build error description messages using what the w/rest.php/v1/revision/{revid}/html endpoint returns (https://en.wikipedia.org/w/rest.php/v1/revision/708326238/html is the request we make to retrieve the HTML on the toolforge side, you can check the response on that link).

@gabina gabina marked this pull request as ready for review April 8, 2024 21:59
@gabina gabina changed the title [WIP] [Outreachy Round 27] Use reference-counter html endpoint [Outreachy Round 27] Use reference-counter html endpoint Apr 8, 2024
@gabina gabina closed this May 14, 2024
@gabina gabina deleted the 5547-outreachy-round-27-use-new-html-toolforge-endpoint branch May 14, 2024 19:17
@gabina gabina restored the 5547-outreachy-round-27-use-new-html-toolforge-endpoint branch May 16, 2024 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant