Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Outreachy Round 27] Clean up code #5675

Conversation

gabina
Copy link
Member

@gabina gabina commented Feb 26, 2024

What this PR does

This PR is part of the "Improve how Wiki Education Dashboard counts references added" project (read issue #5547).
It makes some arbitrary clean up related to the project.

@gabina gabina marked this pull request as draft February 26, 2024 21:56
@gabina gabina changed the title [Outreachy Round 27] Clean up code [WIP] [Outreachy Round 27] Clean up code Feb 26, 2024
@gabina gabina force-pushed the 5547-outreachy-round-27-clean-up-code branch from 13e653e to 554ac7e Compare April 8, 2024 20:26
Comment on lines -28 to -35
# assumes a mediawiki rev_id from the correct Wikipedia
def fetch_data_for_revision_id(rev_id)
result = @api_handler.get_revision_data([rev_id])
features = result.dig(rev_id.to_s, 'features')
rating = result.dig(rev_id.to_s, 'prediction')
return { features:, rating: }
end

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We stopped using this method in PR #5682

@gabina gabina marked this pull request as ready for review April 8, 2024 21:04
@gabina gabina changed the title [WIP] [Outreachy Round 27] Clean up code [Outreachy Round 27] Clean up code Apr 8, 2024
@ragesoss ragesoss merged commit 7454e23 into WikiEducationFoundation:master Apr 16, 2024
1 check passed
@gabina gabina deleted the 5547-outreachy-round-27-clean-up-code branch May 14, 2024 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants