bug fix: Issue with Conditional Question Options Display #5593
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Abishekcs
changed the title
|
LGTM! Nice catch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#closes #5517
What this PR does
Fix : Issue with Conditional Question Options Display
Cause of the bug :
The bug occurs in the JavaScript code
SurveyAdmin.jsand the associated Haml file_form.html.haml. When adding options to a dropdown select (this.$conditional_value_selectfor%select.hidden{"data-conditional-value-select" => ""}), the existing options are not cleared before appending new ones. Consequently, the dropdown retains options from the previous question along with the new ones, leading to unexpected behavior.To fix this, the solution involves adding the line
this.$conditional_value_select.empty();before adding new options. This ensures that the dropdown is cleared of any previous options, providing a clean slate for the options related to the current question.Screenshots
Before:
Before.webm
After:
After.webm