Resolved fetching revisions from wikisource.org

[omChauhanDev]

What this PR does

Fixes #5530
This PR resolves the CORS error that is occurring while fetching revisions from wikisource.org

Screenshots

Before:

After:

[omChauhanDev]

@ragesoss Any idea why it appending .org twice at the end of wikidata.

[ragesoss]

Probably comes from a call to Wiki#domain, as defined in wiki.rb. If a change to the wiki object is making it to the backend, that's probably a mistake; I would expect this issue to be limited to data and code on the JS side of the app.

[omChauhanDev]

Okay, all js tests are passing.

[ragesoss]

I'm not sure. If it's throwing a new error on the back end, then it's probably an unintended side effect of the frontend change you made that is causing unexpected data to reach the backend.

This should probably also include a test that exercises the now-working fetching of wikisource.org.

Now that I think about it again, I'm not certain that a correct solution won't involve a backend change, for example, to ensure that the domain itself is passed along for each Wiki that the frontend deals with. It might be that we need to use a domain supplied by the backend for making queries, rather than using the toWikiDomain function. Either than, or the function will need to deal specifically with the case of wikidata.org.

[omChauhanDev]

@ragesoss i resolved all those previous errors just my modifying the logic of toWikiDomain as you expected earlier that this issue is only related to js side of app . Now only one test is failing but this test is also failing before doing any changes in code (like in master also).

After Doing Changes :

In Master Also :

[ragesoss]

Include a comment here to explain why we have to special-case wikisource.org.

[ragesoss]

Great. Sounds like the failing test is unrelated; I'll look into that. I would also like this PR to include a new test that would have caught the bug before the toWikiDomain change.

[omChauhanDev]

Sure, I have added a new js test which will take care of previous bug in "toWikiDomain" function.

Screenshot

New test with old function

New test after modifying function

[ragesoss]

Looks good, thanks!