Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactored articles_handler to functional component #5585

Conversation

omChauhanDev
Copy link
Contributor

What this PR does

This PR converted the articles_handler.jsx from class to functional component.

Videos

Before:

Before.webm

After:

After.webm

@omChauhanDev
Copy link
Contributor Author

@ragesoss i tried two run tickets_dashboard_spec and namespace_stats_spec locally on the same branch(of pr) to find the issue but locally they are running fine.
image
Can we try running CI / build again or is there anything else that i missed. And when i run full test suite using "bundle exec rspec" then i found several errors showing that "CannotConnectToReddis"
Kindly guide.

@omChauhanDev omChauhanDev force-pushed the RefactorReactClassComponentsStream5 branch from 4254c02 to c297065 Compare January 24, 2024 10:01
@omChauhanDev
Copy link
Contributor Author

@ragesoss i have rebased this branch to avoid any merge conflict.

@ragesoss ragesoss merged commit 0ebf501 into WikiEducationFoundation:master Jan 24, 2024
1 check passed
@omChauhanDev omChauhanDev deleted the RefactorReactClassComponentsStream5 branch January 28, 2024 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants