-
Notifications
You must be signed in to change notification settings - Fork 662
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#5525 - Simplify Program Deletion Process #5583
#5525 - Simplify Program Deletion Process #5583
Conversation
@ragesoss let me know the changes. This is how the delete process is working rn
|
@ragesoss LMKYT regarding the commit |
@ragesoss I think this PR is ready for review. |
@ragesoss I have made a few changes, but i need help in one of the changes required in |
Hi @ragesoss, I have made the necessary changes.
1) Course with only 1 campaignProgram 24 is only in one campaign, so after clicking "Remove and Delete" it removes the program also delete it, to notify that action it provokes a notification. --
Screencast.from.18-02-24.03.20.00.PM.IST.webm2) Course with 1+ campaignsProgram 23 is in more than one campaign, so after clicking "Remove and Delete" it removes the program but dosent delete it, to notify that action it provokes a notification. --
Screencast.from.18-02-24.03.19.37.PM.IST.webm |
@ragesoss i have made the changes |
refs - #5525
/home/ujjwalpathaak/WikiEduDashboard/app/views/campaigns/_course_row.html.haml
- this page has actions mentioned for clone and removeThis is the code for remove button - if i can get a prop to check if user is allowed to delete the course + if no of campaigns = 1
just like it's done here -
/home/ujjwalpathaak/WikiEduDashboard/app/assets/javascripts/components/overview/available_actions.jsx
I can replicate the functinianlity and add the button in the haml file -- so the user can delete the programs directly from campaign's list of programs.