refactored reducer for purity and restrict Edit Mode access

WikiEducationFoundation · Dec 4, 2024 · bcf80c0 · bcf80c0
1 parent eeb502f
commit bcf80c0
Show file tree

Hide file tree

Showing 4 changed files with 17 additions and 12 deletions.
diff --git a/app/assets/javascripts/actions/training_modification_actions.js b/app/assets/javascripts/actions/training_modification_actions.js
@@ -31,8 +31,11 @@ const slideValidationRules = [
 
 // For switching between edit and view mode
 export const getTrainingMode = () => (dispatch) => {
+  const mainDiv = document.getElementById('main');
+  const editMode = JSON.parse(mainDiv.getAttribute('data-training_mode')).editMode;
   dispatch({
     type: SET_TRAINING_MODE,
+    data: { editMode },
   });
 };
 

diff --git a/app/assets/javascripts/reducers/training.js b/app/assets/javascripts/reducers/training.js
@@ -5,8 +5,6 @@ import {
   SLIDE_COMPLETED, SET_TRAINING_MODE
 } from '../constants';
 
-const mainDiv = document.getElementById('main');
-
 const reviewAnswer = function (state, answer) {
   const answerId = parseInt(answer);
   const temp = { ...state, currentSlide: { ...state.currentSlide, selectedAnswer: answerId } };
@@ -106,7 +104,7 @@ export default function training(state = initialState, action) {
     case SET_TRAINING_MODE:
       return {
         ...state,
-        editMode: JSON.parse(mainDiv.getAttribute('data-training_mode')).editMode
+        editMode: data.editMode
       };
     default:
       return state;

diff --git a/app/assets/javascripts/training/components/training_content_handler.jsx b/app/assets/javascripts/training/components/training_content_handler.jsx
@@ -8,6 +8,8 @@ const TrainingContentHandler = (props) => {
   const [showModal, setShowModal] = useState(false);
   const [updatingEditMode, setUpdatingEditMode] = useState(false);
   const dispatch = useDispatch();
+  const { usersignedin: userSignedInStr } = document.getElementById('nav_root').dataset;
+  const userSignedIn = userSignedInStr === 'true';
 
   const toggleModal = () => {
     setShowModal(!showModal);
@@ -42,9 +44,12 @@ const TrainingContentHandler = (props) => {
               <i className="icon icon-plus" />
             </button>
           )}
-          <button className="button dark" onClick={toggleEditMode} style={buttonStyle}>
-            {trainingMode}
-          </button>
+          {/* Switching to edit mode is only allowed for admins */}
+          {userSignedIn && props.currentUser.isAdmin && (
+            <button className="button dark" onClick={toggleEditMode} style={buttonStyle}>
+              {trainingMode}
+            </button>
+          )}
         </div>
       </div>
     </div>

diff --git a/spec/features/training_modification_spec.rb b/spec/features/training_modification_spec.rb
@@ -68,18 +68,17 @@
       before do
         login_as(user, scope: :user)
         visit '/training'
-        click_button 'Switch to Edit Mode'
       end
 
-      it 'does not show the "Create Training Library" button' do
-        expect(page).not_to have_content('Create New Library')
+      it 'does not show the "Switch to Edit Mode" button' do
+        expect(page).not_to have_content('Switch to Edit Mode')
       end
     end
   end
 
   describe 'TrainingCategory' do
     before do
-      login_as(user, scope: :user)
+      login_as(admin, scope: :user)
       visit '/training'
       click_button 'Switch to Edit Mode'
       visit "/training/#{training_library.slug}"
@@ -155,7 +154,7 @@
   # For Training Module
   describe 'TrainingModule' do
     before do
-      login_as(user, scope: :user)
+      login_as(admin, scope: :user)
       visit '/training'
       click_button 'Switch to Edit Mode'
       visit "/training/#{training_library.slug}"
@@ -253,7 +252,7 @@
     end
 
     before do
-      login_as(user, scope: :user)
+      login_as(admin, scope: :user)
       visit '/training'
       click_button 'Switch to Edit Mode'
       sleep 1