Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/platform independence #166

Merged
merged 4 commits into from
Jan 24, 2024
Merged

Conversation

artweb11
Copy link
Contributor

**Platform independence for Stripe, KYC module **

@artweb11 artweb11 requested a review from zigabe January 19, 2024 09:11
Copy link

vercel bot commented Jan 19, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
wii-qare-fe ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 19, 2024 9:12am

Copy link

codecov bot commented Jan 19, 2024

Codecov Report

Attention: 36 lines in your changes are missing coverage. Please review.

Comparison is base (abc1176) 58.19% compared to head (fc3a40b) 57.58%.

Files Patch % Lines
components/molecules/PaymentStub/index.js 35.71% 27 Missing ⚠️
components/atoms/KYCModule/KYCModule.js 40.00% 2 Missing and 1 partial ⚠️
components/atoms/KYCModule/kyc-utils.js 92.30% 2 Missing ⚠️
lib/SavingHelper.js 75.00% 2 Missing ⚠️
components/atoms/Stepper/Forms/payment2.js 50.00% 1 Missing ⚠️
pages/api/session.js 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #166      +/-   ##
==========================================
- Coverage   58.19%   57.58%   -0.61%     
==========================================
  Files         106      111       +5     
  Lines        2332     2379      +47     
  Branches      807      832      +25     
==========================================
+ Hits         1357     1370      +13     
- Misses        891      924      +33     
- Partials       84       85       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@abhiShandy
Copy link
Contributor

This includes a lot of changes to review. How confident are you about the changes?

@sbratu-peakactivity
Copy link

This includes a lot of changes to review. How confident are you about the changes?

I have tested them with the generic stub payment gateway. Also made sure the tests are working. I am pretty confident they will work.

@abhiShandy abhiShandy merged commit 8982873 into main Jan 24, 2024
5 of 6 checks passed
@abhiShandy abhiShandy deleted the feature/platform-independence branch January 24, 2024 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants