Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some issues in Alex's document issues #143

Open
wants to merge 15 commits into
base: main
Choose a base branch
from
Open

Conversation

Frdrcpeter007
Copy link
Contributor

Please add a description of your changes. What are you accomplishing?

Link any issues1 that your changes solve:

What should the reviewer make sure to pay close attention to?

Footnotes

  1. https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue

@vercel
Copy link

vercel bot commented Oct 17, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
wii-qare-fe ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 18, 2023 11:47am

@Frdrcpeter007 Frdrcpeter007 requested a review from zigabe October 17, 2023 13:08
@codecov
Copy link

codecov bot commented Oct 17, 2023

Codecov Report

Attention: 32 lines in your changes are missing coverage. Please review.

Comparison is base (7c5cb49) 49.52% compared to head (e042b37) 48.98%.
Report is 1 commits behind head on main.

❗ Current head e042b37 differs from pull request most recent head d45db80. Consider uploading reports for the commit d45db80 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #143      +/-   ##
==========================================
- Coverage   49.52%   48.98%   -0.54%     
==========================================
  Files         115      115              
  Lines        2294     2321      +27     
  Branches      781      790       +9     
==========================================
+ Hits         1136     1137       +1     
- Misses       1063     1085      +22     
- Partials       95       99       +4     
Files Coverage Δ
components/atoms/Card/Provider/index.js 100.00% <ø> (ø)
components/molecules/Navbar/Drawer.js 44.06% <ø> (ø)
components/organisms/Auth/RegisterForm.js 53.12% <0.00%> (-3.13%) ⬇️
components/atoms/Stepper/Forms/kyc.js 26.92% <18.42%> (-10.34%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

.env Show resolved Hide resolved
@abhiShandy
Copy link
Contributor

I have fixed the test snapshots. Please address my comment and I'll approve it.

@Frdrcpeter007
Copy link
Contributor Author

I have fixed the test snapshots. Please address my comment and I'll approve it.

All the tests have passed but for a long time, there has always been one that did not pass and I already told you at the meeting last time

@zigabe
Copy link
Contributor

zigabe commented Oct 31, 2023

@abhiShandy can you Review and merge this pull request

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants