Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add script to extract pool information #231

Merged
merged 2 commits into from
Dec 18, 2023
Merged

ci: add script to extract pool information #231

merged 2 commits into from
Dec 18, 2023

Conversation

kerber0x
Copy link
Contributor

Description and Motivation

This script is a utility to extract the pool information from the pool factory.

Related Issues


Checklist:

  • I have read Migaloo's contribution guidelines.
  • My pull request has a sound title and description (not something vague like Update index.md)
  • All existing and new tests are passing.
  • I updated/added relevant documentation.
  • The code is formatted properly cargo fmt --all --.
  • Clippy doesn't report any issues cargo clippy -- -D warnings.
  • I have regenerated the schemas if needed cargo schema.

Copy link

codecov bot commented Dec 15, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (1cb7412) 94.51% compared to head (366956a) 94.51%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #231   +/-   ##
=======================================
  Coverage   94.51%   94.51%           
=======================================
  Files         218      218           
  Lines       24720    24720           
=======================================
  Hits        23364    23364           
  Misses       1356     1356           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

0xFable
0xFable previously approved these changes Dec 16, 2023
Copy link
Contributor

@0xFable 0xFable left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks so handy man! Great work. One comment around readability but functionally it looks good.

scripts/deployment/extract_pools.sh Outdated Show resolved Hide resolved
@kerber0x kerber0x merged commit 7d42de9 into main Dec 18, 2023
6 checks passed
@kerber0x kerber0x deleted the ci/pools branch December 18, 2023 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants