Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Google OAuth2 Token 검증 기능 개발 #43

Merged
merged 19 commits into from
Nov 9, 2024
Merged

Google OAuth2 Token 검증 기능 개발 #43

merged 19 commits into from
Nov 9, 2024

Conversation

sjhjack
Copy link
Contributor

@sjhjack sjhjack commented Nov 6, 2024 •
edited
Loading

📑 개요

✅ PR 체크리스트

  • 🔀 PR 제목의 형식을 잘 작성했나요?
  • 💯 테스트는 잘 통과했나요?
  • 🏗️ 빌드는 성공했나요?
  • 🧹 불필요한 코드는 제거했나요?
  • 💭 이슈는 등록했나요?
  • 🏷️ 라벨은 등록했나요?

🚀 상세 작업 내용

  • Google OAuth2 토큰 검증 API 요청을 위한 client 메서드 작성
  • 토큰 검증 Resolver 작성
  • 검증을 위한 커스텀 어노테이션 @Authenticated 작성
  • google-oauth-client 모듈에 Jacoco 추가

📁 ETC

closed: #42

sjhjack added 14 commits November 3, 2024 18:39
@sjhjack
Feat(#42): @authenticated 적용을 위한 Resolver 작성
de603c5
@sjhjack
Rename(#42): Member, SocialMember 위치 변경
6f1c859
@sjhjack
Feat(#42): Google Token 유효성 검사 요청 API 작성
adc2dfd
@sjhjack
Feat(#42): application에서 google client 사용하기 위한 interface와 구현 클래스 추가
1dbbd83
@sjhjack
Feat(#42): 토큰 유효성 검사 응답 레코드 추가
5ae2c46
@sjhjack
Feat(#42): Member 도메인 Repository 추가
b7f44fd
@sjhjack
Feat(#42): Member 도메인 Exception 추가
1c6d817
@sjhjack
Feat(#42): 토큰 유효성 관련 Exception 추가
c4889d5
@sjhjack
Refactor(#42): AuthenticatedArgumentResolver의 파라미터 추가
89577ae
@sjhjack
Refactor(#42): ScheduleInfoMapper의 toJpaScheduleInfo 오버로딩
67dc676
@sjhjack
Refactor(#42): ReviewController의 AuthMember, Authenticated import 위치 변경
d2df374
@sjhjack
Fix(#42): getForObject의 쿼리 파라미터가 세팅되지 않는 현상 해결
c2eaa52
@sjhjack
Feat(#42): google-oauth-client에 Jacoco 추가
5dfc5e3
@sjhjack
Feat(#42): 토큰 검증 테스트 작성
c928b4f
@sjhjack sjhjack requested review from KIMSEI1124 and jiwon83 November 6, 2024 08:52
@sjhjack sjhjack self-assigned this Nov 6, 2024
@sjhjack sjhjack linked an issue Nov 6, 2024 that may be closed by this pull request
Interceptor에서 토큰 검증한다. #42
Closed
3 tasks
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 6, 2024

📄 Jacoco Coverage Report

Overall Project 92.77% 🍏

There is no coverage information present for the Files changed

KIMSEI1124
KIMSEI1124 requested changes Nov 9, 2024
View reviewed changes
Copy link
Member

@KIMSEI1124 KIMSEI1124 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하였습니다!

궁금한점을 댓글로 달아뒀고 한가지는 반드시 수정해야할 것 같습니다!

" 상수 처리하는 부분! "

해당 부분에 대해서 고민한번 해보시고 수정해주시면 감사합니다!

@sjhjack sjhjack requested a review from KIMSEI1124 November 9, 2024 07:03
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 9, 2024

📄 Jacoco Coverage Report

Overall Project 92.77% 🍏

There is no coverage information present for the Files changed

KIMSEI1124
KIMSEI1124 approved these changes Nov 9, 2024
View reviewed changes
Copy link
Member

@KIMSEI1124 KIMSEI1124 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

해당 기능 개발하시느라 고생하셨습니다!

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 9, 2024

📄 Jacoco Coverage Report

Overall Project 92.77% 🍏

There is no coverage information present for the Files changed

@sjhjack sjhjack merged commit fce682a into dev Nov 9, 2024
1 check passed
@sjhjack sjhjack deleted the feat/#42 branch November 9, 2024 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KIMSEI1124 KIMSEI1124 KIMSEI1124 approved these changes

@jiwon83 jiwon83 Awaiting requested review from jiwon83

Assignees

@sjhjack sjhjack

Labels
Module: Core Server Module: Google OAuth2 Client Module: Jpa Member Domain Status: Review Needed Type: ✨ Feature 새로운 기능 추가 Type: ✅ Test 테스트 추가/수정
Projects
What's Your Plan
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Interceptor에서 토큰 검증한다.
2 participants
@sjhjack @KIMSEI1124