Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Google OAuth2 Token API 연동 #40

Merged
merged 20 commits into from
Nov 3, 2024
Merged

Google OAuth2 Token API 연동 #40

merged 20 commits into from
Nov 3, 2024

Conversation

sjhjack
Copy link
Contributor

@sjhjack sjhjack commented Oct 20, 2024

📑 개요

✅ PR 체크리스트

  • 🔀 PR 제목의 형식을 잘 작성했나요?
  • 💯 테스트는 잘 통과했나요?
  • 🏗️ 빌드는 성공했나요?
  • 🧹 불필요한 코드는 제거했나요?
  • 💭 이슈는 등록했나요?
  • 🏷️ 라벨은 등록했나요?

🚀 상세 작업 내용

  • Google OAuth2 Access Token, Refresh Token 발급 요청
  • Google OAuth2 Access Token 재발급 요청
  • GoogleOAuthParamFactory 팩토리 클래스 및 메서드 체이닝 적용
  • 토큰 요청 관련 예외 처리

📁 ETC

colsed: #33

sjhjack added 13 commits October 6, 2024 19:54
@sjhjack
Fix(#33): springframework 의존성 추가
8418b60
@sjhjack
Feat(#33): Google OAuth 토큰 발급을 위한 객체 추가
c6ae577
@sjhjack
Feat(#33): google oauth properties 추가
f1ffefb
@sjhjack
Feat(#33): Google OAuth Token 받아오는 기능 추가
1d8a455
@sjhjack
Refactor(#33): fetchGoogleAOAuthToken 메서드의 파라미터 세팅 부분을 팩토리 패턴과 메서드 체이…
678887e 
…닝으로 수정
@sjhjack
Feat(#33): dev 브랜치 merge
96a06b6
@sjhjack
Chore(#33): application-google 추가
005e8e7
@sjhjack
Chore(#33): application-google 수정
203d7a0
@sjhjack
Refactor(#33): GoogleOAuthParamFactory 클래스 create 메서드의 파라미터 변경
48171f6
@sjhjack
Typo(#33): fetchGoogleOAuthToken 메서드 이름 오탈자 수정
9955ca1
@sjhjack
Feat(#33): 토큰 재발급 및 에러 처리
1557f10
@sjhjack
Refactor(#33): RestTemplate 주입 방식 변경
352deed
@sjhjack
Refactor(#33): HttpEntity 관련 private 함수 non-static으로 변경
ecbd700
@sjhjack sjhjack self-assigned this Oct 20, 2024
@sjhjack sjhjack linked an issue Oct 20, 2024 that may be closed by this pull request
Google API 연동하여 토큰을 발급한다. #33
Closed
1 task
@sjhjack sjhjack requested review from KIMSEI1124 and jiwon83 and removed request for KIMSEI1124 October 20, 2024 11:57
@KIMSEI1124 KIMSEI1124 changed the base branch from main to dev October 20, 2024 11:58
KIMSEI1124
KIMSEI1124 requested changes Oct 20, 2024
View reviewed changes
Copy link
Member

@KIMSEI1124 KIMSEI1124 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

리뷰를 달아뒀습니다!

수정이 필요한 부분이 있어 코멘트를 달아뒀습니다!

@github-actions GitHub Actions
Copy link

📄 Jacoco Coverage Report

Overall Project 92.77% 🍏

There is no coverage information present for the Files changed

@sjhjack sjhjack requested a review from KIMSEI1124 October 26, 2024 02:48
KIMSEI1124
KIMSEI1124 approved these changes Oct 26, 2024
View reviewed changes
Copy link
Member

@KIMSEI1124 KIMSEI1124 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT!

전체적으로 잘 작성하셨습니다!! 다음 작업을 진행하기 전에 해당 브랜치를 머지해주시고 제가 제안하는 내용이 하나 있는데 확인해보시고 변경해야할 것 같으면 수정해주세요!

jiwon83
jiwon83 approved these changes Nov 2, 2024
View reviewed changes
Copy link
Member

@jiwon83 jiwon83 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생했습니다 : )

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 3, 2024

📄 Jacoco Coverage Report

Overall Project 92.77% 🍏

There is no coverage information present for the Files changed

@sjhjack sjhjack merged commit 35c3238 into dev Nov 3, 2024
1 check passed
@sjhjack sjhjack deleted the feat/#33 branch November 3, 2024 06:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KIMSEI1124 KIMSEI1124 KIMSEI1124 approved these changes

@jiwon83 jiwon83 jiwon83 approved these changes

Assignees

@sjhjack sjhjack

Labels
Module: Core Server Module: Google OAuth2 Client Type: ✨ Feature 새로운 기능 추가
Projects
What's Your Plan
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Google API 연동하여 토큰을 발급한다.
3 participants
@sjhjack @KIMSEI1124 @jiwon83