Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

일정 생성 API 작성 #35

Merged
merged 5 commits into from
Oct 6, 2024
Merged

일정 생성 API 작성 #35

merged 5 commits into from
Oct 6, 2024

Conversation

jiwon83
Copy link
Member

@jiwon83 jiwon83 commented Oct 2, 2024 •
edited by KIMSEI1124
Loading

📑 개요

✅ PR 체크리스트

  • 🔀 PR 제목의 형식을 잘 작성했나요?
  • 💯 테스트는 잘 통과했나요?
  • 🏗️ 빌드는 성공했나요?
  • 🧹 불필요한 코드는 제거했나요?
  • 💭 이슈는 등록했나요?
  • 🏷️ 라벨은 등록했나요?

🚀 상세 작업 내용

  • 할일 생성 서비스, 컨트롤러 작성
  • 공통 Message 파일 추가, 관련 com.fasterxml.jackson.core:jackson-annotations:2.15.2 라이브러리 의존성 추가

📁 ETC

closes #26

@jiwon83 jiwon83 self-assigned this Oct 2, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 2, 2024

📄 Image Server Jacoco Coverage Report

Overall Project 88.81% 🍏

There is no coverage information present for the Files changed

KIMSEI1124
KIMSEI1124 requested changes Oct 2, 2024
View reviewed changes
Copy link
Member

@KIMSEI1124 KIMSEI1124 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jiwon83

해당 PR을 열심히 진행해주셔서 감사합니다! 👍🏼
코드를 보면서 궁금한 점과 수정해야할 점에 대해서 자세히 작성해두었습니다.

보시면서 궁금한 점이나 다양한 의견을 남기고 싶으면 코멘트를 달아주세요! 😄

@KIMSEI1124 KIMSEI1124 added the Priority: 🙏 P1 꼭 반영해주세요 (Request changes) label Oct 2, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 6, 2024

📄 Image Server Jacoco Coverage Report

Overall Project 88.81% 🍏

There is no coverage information present for the Files changed

@jiwon83 jiwon83 requested a review from KIMSEI1124 October 6, 2024 07:15
KIMSEI1124
KIMSEI1124 approved these changes Oct 6, 2024
View reviewed changes
Copy link
Member

@KIMSEI1124 KIMSEI1124 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jiwon83 jiwon83 merged commit 2bf3c0b into dev Oct 6, 2024
3 checks passed
@KIMSEI1124 KIMSEI1124 deleted the feat/#26 branch October 6, 2024 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KIMSEI1124 KIMSEI1124 KIMSEI1124 approved these changes

Assignees

@jiwon83 jiwon83

Labels
Module: Common Module: Core Server Module: Jpa Calendar Domain Priority: 🙏 P1 꼭 반영해주세요 (Request changes) Status: Complete Type: 🔧 Config 환경 설정 관련 작업 Type: ✨ Feature 새로운 기능 추가
Projects
What's Your Plan
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jiwon83 @KIMSEI1124