Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/style fixes #916

Merged
merged 12 commits into from
Nov 18, 2024
Merged

Fix/style fixes #916

merged 12 commits into from
Nov 18, 2024

Conversation

HZ991
Copy link
Collaborator

@HZ991 HZ991 commented Oct 28, 2024 •
edited
Loading

Work in progress PR.
Includes following changes:

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Oct 28, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: 4963f21

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@westpac/ui Minor
protoform Patch
site Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel Vercel
Copy link

vercel bot commented Oct 28, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
gel-next-protoform ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 18, 2024 4:53am
gel-next-site ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 18, 2024 4:53am
gel-next-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 18, 2024 4:53am
gel-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 18, 2024 4:53am

@HZ991 HZ991 requested a review from jaortiz October 28, 2024 01:24
jaortiz
jaortiz requested changes Oct 31, 2024
View reviewed changes
Copy link
Contributor

@jaortiz jaortiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also add more tests now progress indicator has more functionality

packages/ui/src/components/progress-indicator/progress-indicator.component.tsx Outdated
size = 'medium',
embedIcon: EmbedIcon,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rename this to just be icon: Icon to be consistent with how we take icons in other components

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is icon: EmbedIcon ok, it is just conflicting with the other 'Icon' import

packages/ui/src/components/progress-indicator/progress-indicator.component.tsx Outdated
className,
children,
color = 'hero',
inverted = false,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed revert back to color prop to be aligned with icon props

@HZ991 HZ991 requested a review from jaortiz November 1, 2024 04:52
@HZ991 HZ991 requested a review from jaortiz November 14, 2024 02:34
@HZ991 HZ991 marked this pull request as ready for review November 15, 2024 01:31
jaortiz
jaortiz reviewed Nov 18, 2024
View reviewed changes
packages/ui/src/components/progress-indicator/progress-indicator.types.ts Outdated
import { IconProps } from '../icon/icon.types.js';

export type ProgressIndicatorProps = IconProps;
export type ProgressIndicatorProps = IconProps & {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor: Update to Omit<IconProps, 'copyrightYear' | 'look'>

@jaortiz jaortiz merged commit d7be6c0 into develop Nov 18, 2024
11 checks passed
@jaortiz jaortiz deleted the fix/style-fixes branch November 18, 2024 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaortiz jaortiz jaortiz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@HZ991 @jaortiz