Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/deep linking built in #910

Merged
merged 7 commits into from
Nov 8, 2024
Merged

Feature/deep linking built in #910

merged 7 commits into from
Nov 8, 2024

Conversation

HZ991
Copy link
Collaborator

@HZ991 HZ991 commented Oct 17, 2024

  • Combines NextJs's Link component with scrollTo for site navigation

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Oct 17, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: df9a783

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel Vercel
Copy link

vercel bot commented Oct 17, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
gel-next-protoform ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 7, 2024 11:50pm
gel-next-site ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 7, 2024 11:50pm
gel-next-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 7, 2024 11:50pm
gel-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 7, 2024 11:50pm

@HZ991 HZ991 changed the base branch from main to develop October 17, 2024 04:16
@HZ991 HZ991 requested a review from kenjishiromajp October 17, 2024 04:23
@HZ991 HZ991 requested a review from jaortiz October 28, 2024 22:15
@jaortiz jaortiz merged commit b50cf34 into develop Nov 8, 2024
11 checks passed
@jaortiz jaortiz deleted the feature/deep-linking-built-in branch November 8, 2024 00:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaortiz jaortiz jaortiz left review comments

@kenjishiromajp kenjishiromajp Awaiting requested review from kenjishiromajp

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@HZ991 @jaortiz