Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/deep linking hannah #897

Closed
wants to merge 3 commits into from
Closed

Feature/deep linking hannah #897

wants to merge 3 commits into from

Conversation

HZ991
Copy link
Collaborator

@HZ991 HZ991 commented Sep 30, 2024

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Sep 30, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: bc34de9

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel Vercel
Copy link

vercel bot commented Sep 30, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
gel-next-protoform ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 2, 2024 5:11am
gel-next-site ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 2, 2024 5:11am
gel-next-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 2, 2024 5:11am
gel-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 2, 2024 5:11am

@HZ991 HZ991 requested a review from jaortiz October 1, 2024 06:14
kenjishiromajp
kenjishiromajp reviewed Oct 2, 2024
View reviewed changes
...s/content-tabs/components/intro/components/table-of-contents/table-of-contents.component.tsx Outdated
if (scrollToHash) {
setTimeout(() => {
scrollToSection();
}, 500);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor: I would setup like const DELAY_TIME_TO_SCROLL = 500; outside not leave the magic numbers (for reference: https://eslint.org/docs/latest/rules/no-magic-numbers) .

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added this to the PR

@HZ991 HZ991 requested a review from kenjishiromajp October 2, 2024 06:06
@HZ991 HZ991 closed this Oct 17, 2024
@jaortiz jaortiz deleted the feature/deep-linking-hannah branch November 18, 2024 23:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaortiz jaortiz Awaiting requested review from jaortiz

@kenjishiromajp kenjishiromajp Awaiting requested review from kenjishiromajp

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@HZ991 @kenjishiromajp