Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes/flexicell style #299

Merged
merged 6 commits into from
Nov 22, 2023
Merged

Fixes/flexicell style #299

merged 6 commits into from
Nov 22, 2023

Conversation

tomjackking
Copy link
Collaborator

  • updated flexi-cell to use new style

  • updated selector after flexi-cell changes

  • added new stories for flexi-cell

tomjackking and others added 3 commits November 17, 2023 15:40
- updated selector after flexi-cell changes
- added new stories for flexi-cell
Copy link

changeset-bot bot commented Nov 17, 2023

⚠️ No Changeset found

Latest commit: af92aab

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Nov 17, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
gel-next-site ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 22, 2023 1:58am
gel-next-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 22, 2023 1:58am

@samithaf
Copy link
Collaborator

@tomjackking looks like we have changed the selector component styles as well. Note that selector already approved by UX team.

@tomjackking
Copy link
Collaborator Author

The most recent update for the Flexi Cell is based on these requirements:

  • Flexi cell will no longer have its internal elements increase in size at larger views.
  • Text and symbols will stay at the Xs size regardless of breakpoint. Icons will use the standard size of 24px.
  • We would like to keep the option of the internal padding increasing from 12px to 18px when required.

@samithaf samithaf merged commit 48f5533 into develop Nov 22, 2023
3 checks passed
@samithaf samithaf deleted the fixes/flexicell-style branch November 22, 2023 02:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants