Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Margins for select + input or select + select #250

Closed
wants to merge 7 commits into from

Conversation

divpreet
Copy link

Fixes #249

Changes include:

  • Added margin for .input-field-select-wrapper
    & + .input-field,
    & + .input-field-select-wrapper

    Affected module/s

  • GUI-source

@dominikwilkowski
Copy link
Contributor

Awesome effort man! However the GUI-source is a collection of git submodules which means we can't make changes to the code in the GUI-source repo. The repo you wanted to change would be https://github.com/WestpacCXTeam/GUI-input-fields. Oh and the _sandbox folder is generated via node and get's all latest versions into one folder so we can test if there are any conflicts.

But don't put your head into it just yet. We will be introducing that forms spacing module mentioned in your issue (#117) which most likely will fix this issue.

Thanks again for the time you put into this. We will fast track this and notify you once it's done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants