Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Margins for select + input or select + select #249

Open
divpreet opened this issue May 17, 2016 · 2 comments
Open

Margins for select + input or select + select #249

divpreet opened this issue May 17, 2016 · 2 comments

Comments

@divpreet
Copy link

Prerequisites

  • [y ] Can you reproduce the problem in the testing area of the GUI?
  • [y ] Are you running the latest version of the affected module?
  • [y ] Did you check if the issue already exists (open or
    closed)?

Description

Steps to Reproduce

  1. Create an dropdown (input-field-select-wrapper) and an input (input-field) or another dropdown (input-field-select-wrapper) after that.
  2. No Margin between a select followed by a select or input
  3. Margins are present for input followed by input or inpur followed by select.

Expected behavior:

Margins should be present between a select and an input (if used consecutively)
Actual behavior:

No Margins

Screenshots

forgel

@dominikwilkowski
Copy link
Contributor

Hi @divpreet

Thanks for the issue and the PR. We love getting people involved and we love getting PRs even more 👍

This issue has been on our radar for some time and is referenced here: #117. The plan is to create a module just for form spacing to fix these little issues. I'd love to get some feedback from you when we finally have time to do it. I'll reference you in the issue and will close this issue once we fix it.

Cheers

@jonnystening
Copy link
Contributor

@justinspencer lets discuss

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants