Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ffmpeg: pre-load required files in integration tests #406

Merged
merged 1 commit into from
Jun 1, 2022

Conversation

bradh
Copy link
Collaborator

@bradh bradh commented May 28, 2022

Motivation and Context

This is an attempt to resolve CI problems as reported at #403.

I'm not sure I understand the root cause, but its now happening pretty reliably, so possibly this is a useful workaround.

Description

Pre-load the required class using extant javacpp-presets capability.

How Has This Been Tested?

Ran it locally, no problems. Will check behaviour with CI.

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@bradh bradh force-pushed the bug_403 branch 2 times, most recently from 1f29aee to 544133f Compare May 28, 2022 11:11
@codecov-commenter
Copy link

codecov-commenter commented May 28, 2022

Codecov Report

Merging #406 (c0898ac) into 2.x (e16dd55) will decrease coverage by 1.72%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##                2.x     #406      +/-   ##
============================================
- Coverage     92.79%   91.06%   -1.73%     
+ Complexity     5669     5608      -61     
============================================
  Files           609      609              
  Lines         14568    14568              
  Branches       1379     1379              
============================================
- Hits          13518    13266     -252     
- Misses          973     1267     +294     
+ Partials         77       35      -42     
Flag Coverage Δ
unittests-api 98.98% <ø> (ø)
unittests-api-ffmpeg 15.85% <ø> (-17.84%) ⬇️
unittests-awt 100.00% <ø> (ø)
unittests-core 98.44% <ø> (ø)
unittests-geoid 100.00% <ø> (ø)
unittests-mimd 97.24% <ø> (ø)
unittests-st0601 99.01% <ø> (ø)
unittests-st0602 99.06% <ø> (ø)
unittests-st0805 99.17% <ø> (ø)
unittests-st0808 99.08% <ø> (ø)
unittests-st0809 99.11% <ø> (ø)
unittests-st1108 99.66% <ø> (ø)
unittests-st1206 99.59% <ø> (ø)
unittests-st1301 98.91% <ø> (ø)
unittests-st1403 100.00% <ø> (ø)
unittests-st1601 100.00% <ø> (ø)
unittests-st1602 100.00% <ø> (ø)
unittests-st1603 98.03% <ø> (ø)
unittests-st1909 99.65% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../src/main/java/org/jmisb/api/video/CodecUtils.java 0.00% <0.00%> (-95.84%) ⬇️
...in/java/org/jmisb/api/video/VideoStreamOutput.java 0.00% <0.00%> (-59.40%) ⬇️
...g/src/main/java/org/jmisb/api/video/FfmpegLog.java 11.76% <0.00%> (-52.95%) ⬇️
...src/main/java/org/jmisb/api/video/VideoOutput.java 0.00% <0.00%> (-51.84%) ⬇️
...ain/java/org/jmisb/api/video/OutputStatistics.java 0.00% <0.00%> (-45.46%) ⬇️
...main/java/org/jmisb/api/video/VideoFileOutput.java 0.00% <0.00%> (-41.67%) ⬇️
...src/main/java/org/jmisb/api/video/FfmpegUtils.java 10.63% <0.00%> (-4.26%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e16dd55...c0898ac. Read the comment docs.

@bradh
Copy link
Collaborator Author

bradh commented May 28, 2022

Motivation and Context

This is an attempt to resolve CI problems as reported at #403.

I'm not sure I understand the root cause, but its now happening pretty reliably, so possibly this is a useful workaround.

Description

Pre-load the required class using extant javacpp-presets capability.

How Has This Been Tested?

Ran it locally, no problems. Will check behaviour with CI.

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@bradh bradh marked this pull request as ready for review May 30, 2022 22:14
@wlfgang wlfgang merged commit c46d544 into WestRidgeSystems:2.x Jun 1, 2022
@bradh bradh deleted the bug_403 branch June 1, 2022 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants