Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add JDK 17 and Ubuntu 22.04 support #405

Merged
merged 1 commit into from
May 28, 2022
Merged

Conversation

bradh
Copy link
Collaborator

@bradh bradh commented May 28, 2022

Motivation and Context

JDK 14 is out-of-life, and JDK 17 is the current LTS.

Also, #403 reports a problem with JDK 14. That might be a broader issue, but can be investigated better if we have a more recent JDK in the CI mix.

Description

Add JDK 17 CI workflow. JDK 14 remains for the purposes of debugging, so this is considered to relate to #403, but not resolve it yet.

How Has This Been Tested?

Only testing as part of the CI for this PR.

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@codecov-commenter
Copy link

codecov-commenter commented May 28, 2022

Codecov Report

Merging #405 (8a52d00) into 2.x (ed8cf4e) will increase coverage by 1.77%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##                2.x     #405      +/-   ##
============================================
+ Coverage     91.06%   92.84%   +1.77%     
- Complexity     5608     5671      +63     
============================================
  Files           609      609              
  Lines         14568    14568              
  Branches       1379     1379              
============================================
+ Hits          13266    13525     +259     
+ Misses         1267      965     -302     
- Partials         35       78      +43     
Flag Coverage Δ
unittests-api 98.98% <ø> (ø)
unittests-api-ffmpeg 34.18% <ø> (+18.32%) ⬆️
unittests-awt 100.00% <ø> (ø)
unittests-core 98.44% <ø> (ø)
unittests-geoid 100.00% <ø> (ø)
unittests-mimd 97.24% <ø> (ø)
unittests-st0601 99.01% <ø> (ø)
unittests-st0602 99.06% <ø> (ø)
unittests-st0805 99.17% <ø> (ø)
unittests-st0808 99.08% <ø> (ø)
unittests-st0809 99.11% <ø> (ø)
unittests-st1108 99.66% <ø> (ø)
unittests-st1206 99.59% <ø> (ø)
unittests-st1301 98.91% <ø> (ø)
unittests-st1403 100.00% <ø> (ø)
unittests-st1601 100.00% <ø> (ø)
unittests-st1602 100.00% <ø> (ø)
unittests-st1603 98.03% <ø> (ø)
unittests-st1909 99.65% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...src/main/java/org/jmisb/api/video/FfmpegUtils.java 14.89% <0.00%> (+4.25%) ⬆️
...main/java/org/jmisb/api/video/VideoFileOutput.java 41.66% <0.00%> (+41.66%) ⬆️
...src/main/java/org/jmisb/api/video/VideoOutput.java 51.83% <0.00%> (+51.83%) ⬆️
...g/src/main/java/org/jmisb/api/video/FfmpegLog.java 64.70% <0.00%> (+52.94%) ⬆️
...ain/java/org/jmisb/api/video/OutputStatistics.java 54.54% <0.00%> (+54.54%) ⬆️
...in/java/org/jmisb/api/video/VideoStreamOutput.java 63.15% <0.00%> (+63.15%) ⬆️
.../src/main/java/org/jmisb/api/video/CodecUtils.java 95.83% <0.00%> (+95.83%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ed8cf4e...8a52d00. Read the comment docs.

@bradh bradh merged commit e16dd55 into WestRidgeSystems:2.x May 28, 2022
@bradh bradh deleted the 2.x_jdk17 branch May 28, 2022 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants