Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable to customized loss and val funcs #526

Closed
wants to merge 9 commits into from

Conversation

WenjieDu
Copy link
Owner

What does this PR do?

  1. fixing Allow users to customize training loss function and validation metric #525;
  2. fixing allow customized loss function for imputation/informer #432;

Before submitting

  • This PR is made to fix a typo or improve the docs (you can dismiss the other checks if this is the case).
  • Was this discussed/approved via a GitHub issue? Please add a link to it if that's the case.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have written necessary tests and already run them locally.

# Conflicts:
#	pypots/classification/base.py
#	pypots/classification/grud/core.py
#	pypots/classification/raindrop/core.py
#	pypots/clustering/base.py
#	pypots/clustering/crli/model.py
#	pypots/clustering/vader/core.py
#	pypots/clustering/vader/model.py
#	pypots/forecasting/base.py
#	pypots/forecasting/csdi/core.py
#	pypots/forecasting/csdi/model.py
#	pypots/forecasting/template/model.py
#	pypots/imputation/base.py
#	pypots/imputation/csdi/core.py
#	pypots/imputation/csdi/model.py
#	pypots/imputation/gpvae/model.py
#	pypots/imputation/nonstationary_transformer/core.py
#	pypots/imputation/saits/core.py
#	pypots/imputation/saits/model.py
#	pypots/imputation/template/model.py
#	pypots/imputation/usgan/core.py
#	pypots/nn/modules/csdi/backbone.py
@coveralls
Copy link
Collaborator

coveralls commented Sep 25, 2024

Pull Request Test Coverage Report for Build 11066608932

Details

  • 253 of 296 (85.47%) changed or added relevant lines in 93 files are covered.
  • 10 unchanged lines in 10 files lost coverage.
  • Overall coverage decreased (-0.1%) to 83.31%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pypots/classification/base.py 16 17 94.12%
pypots/clustering/base.py 0 1 0.0%
pypots/clustering/vader/model.py 2 3 66.67%
pypots/forecasting/csdi/model.py 5 6 83.33%
pypots/imputation/base.py 10 11 90.91%
pypots/imputation/csdi/model.py 5 6 83.33%
pypots/imputation/gpvae/model.py 3 4 75.0%
pypots/forecasting/base.py 1 3 33.33%
pypots/base.py 11 19 57.89%
pypots/nn/modules/loss.py 0 12 0.0%
Files with Coverage Reduction New Missed Lines %
pypots/imputation/csdi/model.py 1 86.03%
pypots/imputation/base.py 1 78.63%
pypots/classification/base.py 1 78.05%
pypots/forecasting/csdi/model.py 1 86.43%
pypots/clustering/vader/model.py 1 85.93%
pypots/clustering/base.py 1 38.83%
pypots/forecasting/base.py 1 36.94%
pypots/imputation/gpvae/model.py 1 86.21%
pypots/imputation/itransformer/model.py 1 94.94%
pypots/imputation/transformer/model.py 1 94.87%
Totals Coverage Status
Change from base Build 11056787314: -0.1%
Covered Lines: 11376
Relevant Lines: 13655

💛 - Coveralls

Copy link

This pull request had no activity for 14 days. It will be closed in 1 week unless there is some new activity.

@github-actions github-actions bot added the stale label Oct 12, 2024
@github-actions github-actions bot closed this Oct 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants