Merge pull request #469 from WenjieDu/(fix)model_saving

Fix saving failed when the strategy is 'better'
WenjieDu · Jul 21, 2024 · 5f1baa6 · 5f1baa6
2 parents e226073 + 3755fde
commit 5f1baa6
Show file tree

Hide file tree

Showing 9 changed files with 9 additions and 9 deletions.
diff --git a/pypots/classification/base.py b/pypots/classification/base.py
@@ -353,7 +353,7 @@ def _train_model(
 
                 # save the model if necessary
                 self._auto_save_model_if_necessary(
-                    confirm_saving=mean_loss < self.best_loss,
+                    confirm_saving=self.best_epoch == epoch,
                     saving_name=f"{self.__class__.__name__}_epoch{epoch}_loss{mean_loss}",
                 )
 

diff --git a/pypots/clustering/crli/model.py b/pypots/clustering/crli/model.py
@@ -309,7 +309,7 @@ def _train_model(
 
                 # save the model if necessary
                 self._auto_save_model_if_necessary(
-                    confirm_saving=mean_loss < self.best_loss,
+                    confirm_saving=self.best_epoch == epoch,
                     saving_name=f"{self.__class__.__name__}_epoch{epoch}_loss{mean_loss:.4f}",
                 )
 

diff --git a/pypots/clustering/vader/model.py b/pypots/clustering/vader/model.py
@@ -317,7 +317,7 @@ def _train_model(
 
                 # save the model if necessary
                 self._auto_save_model_if_necessary(
-                    confirm_saving=mean_loss < self.best_loss,
+                    confirm_saving=self.best_epoch == epoch,
                     saving_name=f"{self.__class__.__name__}_epoch{epoch}_loss{mean_loss}",
                 )
 

diff --git a/pypots/forecasting/base.py b/pypots/forecasting/base.py
@@ -350,7 +350,7 @@ def _train_model(
 
                 # save the model if necessary
                 self._auto_save_model_if_necessary(
-                    confirm_saving=mean_loss < self.best_loss,
+                    confirm_saving=self.best_epoch == epoch,
                     saving_name=f"{self.__class__.__name__}_epoch{epoch}_loss{mean_loss}",
                 )
 

diff --git a/pypots/forecasting/csdi/model.py b/pypots/forecasting/csdi/model.py
@@ -313,7 +313,7 @@ def _train_model(
 
                 # save the model if necessary
                 self._auto_save_model_if_necessary(
-                    confirm_saving=mean_loss < self.best_loss,
+                    confirm_saving=self.best_epoch == epoch,
                     saving_name=f"{self.__class__.__name__}_epoch{epoch}_loss{mean_loss}",
                 )
 

diff --git a/pypots/imputation/base.py b/pypots/imputation/base.py
@@ -350,7 +350,7 @@ def _train_model(
 
                 # save the model if necessary
                 self._auto_save_model_if_necessary(
-                    confirm_saving=mean_loss < self.best_loss,
+                    confirm_saving=self.best_epoch == epoch,
                     saving_name=f"{self.__class__.__name__}_epoch{epoch}_loss{mean_loss}",
                 )
 

diff --git a/pypots/imputation/csdi/model.py b/pypots/imputation/csdi/model.py
@@ -293,7 +293,7 @@ def _train_model(
 
                 # save the model if necessary
                 self._auto_save_model_if_necessary(
-                    confirm_saving=mean_loss < self.best_loss,
+                    confirm_saving=self.best_epoch == epoch,
                     saving_name=f"{self.__class__.__name__}_epoch{epoch}_loss{mean_loss}",
                 )
 

diff --git a/pypots/imputation/gpvae/model.py b/pypots/imputation/gpvae/model.py
@@ -320,7 +320,7 @@ def _train_model(
 
                 # save the model if necessary
                 self._auto_save_model_if_necessary(
-                    confirm_saving=mean_loss < self.best_loss,
+                    confirm_saving=self.best_epoch == epoch,
                     saving_name=f"{self.__class__.__name__}_epoch{epoch}_loss{mean_loss}",
                 )
 

diff --git a/pypots/imputation/usgan/model.py b/pypots/imputation/usgan/model.py
@@ -334,7 +334,7 @@ def _train_model(
 
                 # save the model if necessary
                 self._auto_save_model_if_necessary(
-                    confirm_saving=mean_loss < self.best_loss,
+                    confirm_saving=self.best_epoch == epoch,
                     saving_name=f"{self.__class__.__name__}_epoch{epoch}_loss{mean_loss}",
                 )