Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing Namespace Option Ending with Backslash in LiftMigration Command #85

Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Console/Commands/LiftMigration.php
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ final class LiftMigration extends Command
public function handle(): int
{
try {
$class = $this->option('namespace') . '\\' . $this->argument('model'); // @phpstan-ignore-line
$class = rtrim($this->option('namespace'), '\\') . '\\' . $this->argument('model'); // @phpstan-ignore-line

if (! class_exists($class)) {
$this->error("Model {$class} not found.");
Expand Down
22 changes: 22 additions & 0 deletions tests/Feature/LiftMigrationTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,17 @@

unlink($migrationClass);
});

it('generates a migration file for a model if namespace ends with slash', function () {
$migrationClass = database_path('migrations/' . date('Y_m_d_His') . '_create_users_migration_table.php');

$this->artisan('lift:migration UserMigration --namespace=Tests\\\Datasets\\')
->assertExitCode(0);

expect($migrationClass)->toBeFileWithContent(UserMigrationCreate());

unlink($migrationClass);
});
});

describe('UPDATE TABLE', function () {
Expand All @@ -26,6 +37,17 @@

unlink($migrationClass);
});

it('generates a migration file for a model adding and dropping columns if namespace ends with slash', function () {
$migrationClass = database_path('migrations/' . date('Y_m_d_His') . '_update_users_migrated_table.php');

$this->artisan('lift:migration UserMigratedUpdateTable --namespace=Tests\\\Datasets\\')
->assertExitCode(0);

expect($migrationClass)->toBeFileWithContent(UserMigrationAddColumns());

unlink($migrationClass);
});
});

function UserMigrationCreate(): string
Expand Down