Merge pull request #253 from eivydas/invalid-job-content

Throw exception on invalid job content
Webador · Oct 18, 2022 · 1c79402 · 1c79402
2 parents 30757da + 5aca920
commit 1c79402
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 1 deletion.
diff --git a/composer.json b/composer.json
@@ -33,6 +33,7 @@
     ],
     "require": {
         "php": "~7.4.0 || ~8.0.0 || ~8.1.0",
+        "ext-json": "*",
         "laminas/laminas-eventmanager": "^3.4",
         "laminas/laminas-servicemanager": "^3.11",
         "laminas/laminas-stdlib": "^3.7.1",

diff --git a/src/Queue/AbstractQueue.php b/src/Queue/AbstractQueue.php
@@ -90,6 +90,6 @@ public function serializeJob(JobInterface $job): string
             $data['content'] = base64_encode($data['content']);
         }
 
-        return json_encode($data);
+        return json_encode($data, JSON_THROW_ON_ERROR);
     }
 }
diff --git a/tests/src/Queue/QueueTest.php b/tests/src/Queue/QueueTest.php
@@ -2,6 +2,7 @@
 
 namespace SlmQueueTest\Queue;
 
+use JsonException;
 use Laminas\ServiceManager\ServiceManager;
 use PHPUnit\Framework\MockObject\MockObject;
 use PHPUnit\Framework\TestCase;
@@ -133,6 +134,17 @@ public function testCorrectlySerializeJobServiceName(): void
         static::assertEquals($expected, $actual);
     }
 
+    public function testInvalidSerializeJobContent(): void
+    {
+        $job = new SimpleJob();
+        $job->setMetadata('__name__', 'SimpleJob');
+        $job->setContent(chr(128));
+
+        $this->expectException(JsonException::class);
+
+        $this->queue->serializeJob($job);
+    }
+
     public function testCanCreateJobWithFQCN(): void
     {
         $this->jobPluginManager->expects($this->once())