Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Docs] : Update and improve readme files in Resources #48

Merged
merged 27 commits into from
Oct 23, 2022
Merged

[Docs] : Update and improve readme files in Resources #48

merged 27 commits into from
Oct 23, 2022

Conversation

ShubhamJagtap2000
Copy link
Contributor

@ShubhamJagtap2000 ShubhamJagtap2000 commented Oct 18, 2022 •
edited
Loading

Related Issue

  • Information about the related issue

Closes: #49, #52

Describe the changes you've made

I have changed the YouTube video resources you added in the Resources file of this repo.

I have also added the video title (alt text) so that one can know the title of the video as well.

Type of change

Improvement in Markdown, making content more interactive and exclusive. Styling and formatting update is done.
What sort of change have you made:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, local variables)
  • [] Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update.
  • This change requires a documentation update

How Has This Been Tested?

Yes, I have edited some HTML code to show a thumbnail of the Youtube video link whereas there were only text links before.

Also, I have kept previous code as comment in case you want to edit it more.
I have tested the links to each video.

Checklist

  • My code follows the guidelines of this project.
  • I have performed a self-review of my own code.
  • I have commented on my code, particularly wherever it was hard to understand.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • Any dependent changes have been merged and published in downstream modules.

Screenshots (if applicable)

Original Updated

image
| image |

Code of Conduct

@netlify
Copy link

netlify bot commented Oct 18, 2022 •
edited
Loading

✅ Deploy Preview for genuine-sprinkles-dcf6c9 ready!

Name Link
🔨 Latest commit b510cff
🔍 Latest deploy log https://app.netlify.com/sites/genuine-sprinkles-dcf6c9/deploys/6354e540d330de0008bbc7ae
😎 Deploy Preview https://deploy-preview-48--genuine-sprinkles-dcf6c9.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@mkubdev mkubdev requested a review from Panquesito7 October 18, 2022 08:20
@Panquesito7 Panquesito7 added the documentation Improvements or additions to documentation label Oct 18, 2022
Panquesito7
Panquesito7 requested changes Oct 19, 2022
View reviewed changes
Copy link
Member

@Panquesito7 Panquesito7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You might want to do the same with other instances as well.

@ShubhamJagtap2000
Copy link
Contributor Author

You might want to do the same with other instances as well.

I just committed the requested changes. Can we resolve this now or more changes are required?

@ShubhamJagtap2000 ShubhamJagtap2000 mentioned this pull request Oct 20, 2022
Closed
Panquesito7
Panquesito7 requested changes Oct 20, 2022
View reviewed changes
docs/🤩 Resources/Roadmap to learn Blockchain development.md Outdated
**Full Roadmap to learn Blockchain development**

Click below to see the video

<iframe width="800" height="400" src="https://www.youtube.com/embed/ci_AIMCF-HA" title="YouTube video player" frameborder="0" allow="accelerometer; autoplay; clipboard-write; encrypted-media; gyroscope; picture-in-picture" allowfullscreen></iframe>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should remove this. It doesn't even show up well on Markdown.

image

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, that was already included in the README, and it's YouTube image has been corrupt so cannot display as we did for others. Will remove this as you say.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commented it, tell me if I should delete all the commented content from all the files. Thank you.

mkubdev
mkubdev approved these changes Oct 21, 2022
View reviewed changes
Copy link
Contributor

@mkubdev mkubdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, thanks for this changes! LGTM

@ShubhamJagtap2000
Copy link
Contributor Author

Hi, thanks for this changes! LGTM

Thank you.

@Panquesito7
Copy link
Member

Panquesito7 commented Oct 21, 2022 •
edited
Loading

Seems the CI is failing due to various HTML codes in the Markdown files that are invalid.
Should we remove them? We're not going to use them anyways.

@ShubhamJagtap2000
Copy link
Contributor Author

Seems the CI is failing due to various HTML codes in the Markdown files that are invalid. Should we remove them? We're not going to use them anyways.

You mean unwanted commented code?

@Panquesito7
Copy link
Member

Seems the CI is failing due to various HTML codes in the Markdown files that are invalid. Should we remove them? We're not going to use them anyways.

You mean unwanted commented code?

Yep.

@ShubhamJagtap2000
Copy link
Contributor Author

Seems the CI is failing due to various HTML codes in the Markdown files that are invalid. Should we remove them? We're not going to use them anyways.

You mean unwanted commented code?

Yep.

Going to do it

@ShubhamJagtap2000
Copy link
Contributor Author

Seems the CI is failing due to various HTML codes in the Markdown files that are invalid. Should we remove them? We're not going to use them anyways.

You mean unwanted commented code?

Yep.

Just did the changes. Please review.

@shuklaritvik06 shuklaritvik06 merged commit 943bf49 into WebXDAO:main Oct 23, 2022
@ShubhamJagtap2000
Copy link
Contributor Author

Thank you so much. Glad to co-author with you @shuklaritvik06 @Panquesito7 @mkubdev. Looking forward to future contributions.

@ShubhamJagtap2000
Copy link
Contributor Author

Can I be a member of this org? Provided I haven't started in the blockchain field yet.

@shuklaritvik06
Copy link
Member

shuklaritvik06 commented Oct 24, 2022 •
edited
Loading

Can I be a member of this org? Provided I haven't started in the blockchain field yet.

Yes you can, in fact everyone can, there is nothing like I haven't started, you can come, learn and grow with us together, let's make WebXDAO much more grand ❤️

Just open an issue in start here repo with the template invite me to WebXDAO bot will send you an invite.

And Happy Diwali 🥳❤️🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkubdev mkubdev mkubdev approved these changes

@shuklaritvik06 shuklaritvik06 shuklaritvik06 approved these changes

@Panquesito7 Panquesito7 Awaiting requested review from Panquesito7

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEATURE] : Improved markdown in Resources directory
4 participants
@ShubhamJagtap2000 @Panquesito7 @shuklaritvik06 @mkubdev