Added test cases related to Firmware Upgrade plugin #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wouterlucas
requested changes
Jun 5, 2020
| sleep: 5, | ||
| test() { | ||
| //TODO - Update the test to enter the 'name', 'location', 'type', 'progressinterval', 'hmac' through User prompt | ||
| return firmwareUpgrade.call(this, 'name', 'location', 'type', 'progressinterval', 'hmac') |
There was a problem hiding this comment.
Do we want to merge this already or wait for an ability to fill this in with meaningful values?
| test() { | ||
| //TODO - Update the test to enter the 'name', 'location', 'type', 'progressinterval', 'hmac' through User prompt | ||
| firmwareUpgrade.call(this, 'name', 'location', 'type', 'progressinterval', 'hmac') | ||
| return firmwareUpgrade.call(this, 'name', 'location', 'type', 'progressinterval', 'hmac') |
There was a problem hiding this comment.
Suggest to use promise.all to run 2 promises in parallel, for reference:
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Promise/all
And same here, guess we wait until we can fill in something meaninful to avoid false negative results?
| steps: [ | ||
| { | ||
| description: | ||
| 'Invoke Upgrade firmware when already firmware upgrade in progres and validate the result', |
There was a problem hiding this comment.
need to update description
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added below test cases in this PR :
Firmware_Upgrade_Upgrade_001.test.js
Firmware_Upgrade_Upgrade_002.test.js
Firmware_Upgrade_Upgrade_003.test.js
Note: These tests are not to be merged to master until User-prompt feature is implemented as the tests need to be updated