Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Shell Tests #42

Open
wants to merge 22 commits into
base: main
Choose a base branch
from

Conversation

camillobruni
Copy link
Contributor

Add support for running basic cli.js tests with npm run test:jsc, npm run test:spidermonkey, npm run test:v8

@camillobruni
Copy link
Contributor Author

I think this is now working...
We probably still want to add some additional validation at some point (especially for the web versions of these workloads),

@camillobruni
Copy link
Contributor Author

Going to skip JSC for now, since we get a "rate limit exceeded" warning from querying the amazon buckets... not sure if there is an easier way to install this. I presume we can enable this again after a while and caching will prevent us from breakage.

@kmiller68
Copy link
Contributor

Fun fact jsc exists on Mac but it's not part of the default PATH. You can run it from /System/Library/Frameworks/JavaScriptCore.framework/Versions/Current/Helpers/jsc. I think it moved at some point but that was a few years ago so that path should be fine.

@camillobruni
Copy link
Contributor Author

ah cool, ok, I'll add a macos check and use that as the default ther, keeping jsvu as backup for other platforms.

Copy link

netlify bot commented Mar 26, 2025

Deploy Preview for webkit-jetstream-preview ready!

Name Link
🔨 Latest commit b52131f
🔍 Latest deploy log https://app.netlify.com/sites/webkit-jetstream-preview/deploys/67ea86ef04952100089e82f4
😎 Deploy Preview https://deploy-preview-42--webkit-jetstream-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@camillobruni
Copy link
Contributor Author

PTAL again... I've re-added JSC support.
Looks like there might be a wasm failure due to the an older JSC version?

  Running Dart-flute-wasm:
  JetStream3 failed: CompileError: WebAssembly.Module doesn't parse at byte 15: 0th type failed to parse because sub types are not enabled
  undefined

Copy link
Contributor

@kmiller68 kmiller68 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@camillobruni camillobruni mentioned this pull request Apr 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants