Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/versioning script #33

Merged
merged 5 commits into from
Aug 26, 2024
Merged

Feature/versioning script #33

merged 5 commits into from
Aug 26, 2024

Conversation

khleomix
Copy link
Contributor

Closes

N/A

Link to test

Locally

Description

This PR implements an automated versioning system that updates the VERSION and BUILD numbers based on merge events to the main branch. The VERSION remains manually controlled through the .env file, while the BUILD number is automatically incremented during merges to main.

Related Tickets & Documents

Mobile & Desktop Screenshots/Recordings

N/A

Added to documentation?

  • 📜 README.md
  • 📓 Confluence
  • 🙅 No documentation needed

Added tests?

  • 👍 Yes
  • 🙅 No, because they aren't needed
  • 🙋 No, because I need help

Testing Instructions


Reviewer's Testing Checklist

As a reviewer, please verify that the relevant testing criteria are fulfilled and confirmed before approving this Pull Request.

  • Visual Regression Testing: Ensure that existing functionality is not negatively impacted by the changes.
  • Cross-Browser Compatibility: Test on major browsers (Chrome, Firefox, Safari) to ensure compatibility.
  • Mobile Responsiveness: Confirm that the changes are responsive and functional on various mobile devices.
  • Theme Compatibility: Ensure that the changes do not adversely affect the site's theme and styling.
  • Linting: Check that the code passes all linting checks (PHPCS, ESLint, SassLint). Check if PR passes code quality check.
  • Accessibility Testing: Validate that the changes comply with accessibility standards. Run npm run a11y.
  • Security Best Practices: Ensure that the code follows WordPress security best practices. Check if PR passes security check.
  • Documentation: Ensure that any new features or changes are appropriately documented in the README.md or Confluence.
  • Post-Deployment Tasks: Check if there are any tasks that need to be performed after deployment.

[optional] Additional Reviewer Notes or Considerations?

@khleomix khleomix self-assigned this Aug 23, 2024
@khleomix khleomix requested a review from lswilson August 23, 2024 22:10
Copy link
Member

@lswilson lswilson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great @khleomix - thank you! Approved

@lswilson lswilson merged commit 92b15db into main Aug 26, 2024
4 checks passed
@lswilson lswilson deleted the feature/Versioning-script branch August 26, 2024 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants