Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore/reorg scss #28

Merged
merged 6 commits into from
Jun 28, 2024
Merged

Chore/reorg scss #28

merged 6 commits into from
Jun 28, 2024

Conversation

itsamoreh
Copy link
Contributor

NOTE: This is a follow up PR for #27 that fixes some issues after rebasing on main.

Closes

N/A

Link to test

N/A

Description

  • Reorganize scss files and directories
    • Make directories more literal (e.g. template-parts to style WordPress Template Parts)
    • Use _index.scss so we can get rid of the double import (@import './base' instead of @import './base/base')
    • Remove underscore from scss files other than index, so that index can be at the top of the dir
      • The underscores are not required anyway, this keeps things nice and organized visually
    • Remove the components directory and move form styles to base
      • In the spirit of literal directory names, since there is nothing called "components" in WP, this PR removes this dir and moves the form styles to base since they style bare html elements like input and select

Mobile & Desktop Screenshots/Recordings

2024-06-21-11 50 20

2024-06-21-11 51 04

Added to documentation?

  • 📜 README.md

Testing Instructions

  1. Pull this branch, build the theme
  2. Verify that styles are building correctly

Reviewer's Testing Checklist

As a reviewer, please verify that the relevant testing criteria are fulfilled and confirmed before approving this Pull Request.

  • Visual Regression Testing: Ensure that existing functionality is not negatively impacted by the changes.
  • Cross-Browser Compatibility: Test on major browsers (Chrome, Firefox, Safari) to ensure compatibility.
  • Mobile Responsiveness: Confirm that the changes are responsive and functional on various mobile devices.
  • Theme Compatibility: Ensure that the changes do not adversely affect the site's theme and styling.
  • Linting: Check that the code passes all linting checks (PHPCS, ESLint, SassLint). Check if PR passes code quality check.
  • Accessibility Testing: Validate that the changes comply with accessibility standards. Run npm run a11y.
  • Security Best Practices: Ensure that the code follows WordPress security best practices. Check if PR passes security check.
  • Documentation: Ensure that any new features or changes are appropriately documented in the README.md or Confluence.
  • Post-Deployment Tasks: Check if there are any tasks that need to be performed after deployment.

[optional] Additional Reviewer Notes or Considerations?

@khleomix
Copy link
Contributor

@itsamoreh thanks! This was in my to-do. I'll also need to rename from assets to src since that is the default folder, that way, we don't have to use the dir flag for wp-scripts. I'll do that since that might require quiet a few changes in webpack config. Will review once I'm back on Monday.

Copy link
Contributor

@khleomix khleomix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@itsamoreh just a couple things with the generated blocks folder

.gitignore Show resolved Hide resolved
.stylelintignore Show resolved Hide resolved
@itsamoreh itsamoreh requested a review from khleomix June 26, 2024 20:53
Copy link
Contributor

@khleomix khleomix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@khleomix khleomix merged commit c5d404f into main Jun 28, 2024
7 checks passed
@khleomix khleomix deleted the chore/reorg-scss branch June 28, 2024 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants