-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chore/reorg scss #28
Chore/reorg scss #28
Conversation
@itsamoreh thanks! This was in my to-do. I'll also need to rename from assets to src since that is the default folder, that way, we don't have to use the dir flag for wp-scripts. I'll do that since that might require quiet a few changes in webpack config. Will review once I'm back on Monday. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@itsamoreh just a couple things with the generated blocks folder
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
NOTE: This is a follow up PR for #27 that fixes some issues after rebasing on
main
.Closes
N/A
Link to test
N/A
Description
template-parts
to style WordPress Template Parts)_index.scss
so we can get rid of the double import (@import './base'
instead of@import './base/base'
)components
directory and move form styles tobase
base
since they style bare html elements likeinput
andselect
Mobile & Desktop Screenshots/Recordings
Added to documentation?
Testing Instructions
Reviewer's Testing Checklist
As a reviewer, please verify that the relevant testing criteria are fulfilled and confirmed before approving this Pull Request.
npm run a11y
.[optional] Additional Reviewer Notes or Considerations?