-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor block settings #95
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ravewebdev
force-pushed
the
enhancement/91-refactor-block-settings
branch
2 times, most recently
from
September 8, 2020 16:48
459508e
to
c982fd3
Compare
ravewebdev
force-pushed
the
enhancement/91-refactor-block-settings
branch
2 times, most recently
from
September 8, 2020 22:54
ee335e0
to
861ab0b
Compare
Move optional props to bottom.
ravewebdev
force-pushed
the
enhancement/91-refactor-block-settings
branch
from
September 9, 2020 18:09
8037cc9
to
0c1154d
Compare
gregrickaby
approved these changes
Sep 9, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #91
DESCRIPTION
ColorPaletteControl
.BackgroundSettingsPanel
.BackgroundSettingsPanel
's media controls to new component,MediaControl
.ContrastChecker
component toSlide
andAccordions
blocks to check color contrast and output warning if needed.Slide
component to use new panel/control components.Accordions
block to use custom color HOCs insave
function andwithColors
HOC inedit
function (fixes color selection functionality).config.js
.SCREENSHOTS
Slide
block showing color contrast warning when using background color:Accordions
block showing color selections:OTHER
STEPS TO VERIFY
Carousel
block.Accordion
block.DOCUMENTATION
Will this pull request require updating the WDS Blocks wiki?
Documentation included in
README.md
files for new components. Further documentation to be added as per #88.