Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add color processing system to theme json #76

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

schlotterer
Copy link
Contributor

This PR applies some build lessons to the theme.json.
Primarily this update adds a custom section to the json that will allow us to create an css vars we want (colors and more) without having to add a million colors to the pallet in the admin. This update separate the need for css color vars to work with in the theme and the need for a color pallet in the admin that is curated for the end user.
This update also takes advantage of the color-mix css property to dynamically build color variations and allow for faster scaffolding.
This update also cleaned up some color vars that were being used in the markup but were never set.

What type of PR is this? (put an x to all applicable)

  • [ x] 🍕 Feature
  • 🐛 Bug Fix
  • 📝 Documentation Update
  • [x ] 🎨 Style
  • [ x] 🧑‍💻 Code Refactor
  • 🔥 Performance Improvements
  • ✅ Test
  • 🤖 Build
  • 🔁 CI
  • 📦 Chore (Release)
  • ⏩ Revert

Mobile & Desktop Screenshots/Recordings

Screenshot 2023-09-29 at 6 46 06 AM
Screenshot 2023-09-29 at 6 46 27 AM

Added tests?

  • 👍 yes
  • [x ] 🙅 no, because they aren't needed
  • 🙋 no, because I need help

Added to documentation?

  • 📜 README.md
  • 📓 Confluence
  • [ x] 🙅 no documentation needed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant