Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adds prefers-reduced-motion to scroll behaviour #73

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

adds prefers-reduced-motion to scroll behaviour #73

wants to merge 2 commits into from

Conversation

mediaformat
Copy link

@mediaformat mediaformat commented Sep 26, 2023 •
edited
Loading

Closes

What type of PR is this? (put an x to all applicable)

  • 🍕 Feature
  • 🐛 Bug Fix
  • 📝 Documentation Update
  • 🎨 Style
  • 🧑‍💻 Code Refactor
  • 🔥 Performance Improvements
  • ✅ Test
  • 🤖 Build
  • 🔁 CI
  • 📦 Chore (Release)
  • ⏩ Revert

Link to test

Description

This PR adds media query detection of user preferences relating to motion, and applies scroll-behavior: auto;.

Related Tickets & Documents

Mobile & Desktop Screenshots/Recordings

Screen.Recording.2023-09-26.at.5.05.50.PM.mov

Caption: Video starts with reduced motion pref true, I turn it off and it restores smooth-scroll behaviour.

Added tests?

  • 👍 yes
  • 🙅 no, because they aren't needed
  • 🙋 no, because I need help

Added to documentation?

  • 📜 README.md
  • 📓 Confluence
  • 🙅 no documentation needed

Others

  • 🦮 Is this issue accessible? (Section 508/WCAG 2.0AA)
  • 🙌 Does this issue pass all the linting? (PHPCS, ESLint, SassLint)

@mediaformat
Copy link
Author

@khleomix if you want to test this you can refer to an implementation an Paramount

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khleomix khleomix Awaiting requested review from khleomix khleomix is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@mediaformat