Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/cleanup #42

Merged
merged 20 commits into from
Aug 11, 2023
Merged

Feature/cleanup #42

merged 20 commits into from
Aug 11, 2023

Conversation

khleomix
Copy link
Contributor

@khleomix khleomix commented Aug 8, 2023

Closes

N/A

What type of PR is this? (put an x to all applicable)

  • 🍕 Feature
  • 🐛 Bug Fix
  • 📝 Documentation Update
  • 🎨 Style
  • 🧑‍💻 Code Refactor
  • 🔥 Performance Improvements
  • ✅ Test
  • 🤖 Build
  • 🔁 CI
  • 📦 Chore (Release)
  • ⏩ Revert

Link to test

funderscores
Apache Lock is in 1Password under funderscores

Description

  • Refactored custom block category hook for improved efficiency.
  • Added workflow, PR template, and updated the screenshot.
  • Removed redundant functions and files.
  • Enhanced editor styles to outline only when selected.
  • Fixed a template error on load.
  • Updated the WPCLI command for compatibility.

Related Tickets & Documents

Mobile & Desktop Screenshots/Recordings

Added tests?

  • 👍 yes
  • 🙅 no, because they aren't needed
  • 🙋 no, because I need help

Added to documentation?

  • 📜 README.md
  • 📓 Confluence
  • 🙅 no documentation needed

Others

  • 🦮 Is this issue accessible? (Section 508/WCAG 2.0AA)
  • 🙌 Does this issue pass all the linting? (PHPCS, ESLint, SassLint)

[optional] Are there any post-deployment tasks we need to perform?

@khleomix khleomix requested a review from itsamoreh August 8, 2023 19:17
@khleomix khleomix self-assigned this Aug 8, 2023
Copy link
Collaborator

@itsamoreh itsamoreh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

screen-capture 2023-08-11 at 12 04 40 PM

This makes me happy! Very nice, everything looks good.

@khleomix khleomix merged commit 31e5a67 into main Aug 11, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants