Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/WDSUS-34 fix layout container #32

Closed
wants to merge 8 commits into from

Conversation

khleomix
Copy link
Contributor

@khleomix khleomix commented Jul 28, 2023

Closes

#WDSUS-34

What type of PR is this? (put an x to all applicable)

  • 🍕 Feature
  • 🐛 Bug Fix
  • 📝 Documentation Update
  • 🎨 Style
  • 🧑‍💻 Code Refactor
  • 🔥 Performance Improvements
  • ✅ Test
  • 🤖 Build
  • 🔁 CI
  • 📦 Chore (Release)
  • ⏩ Revert

Link to test

Test locally

Description

  • This PR adds the PR template and workflow
  • Change block outline in the editor for better user experience
  • Change screenshot so that it looks different from wd_s
  • Add CodeQL action to set up GitHub code scanning
  • Add dependabot checks

Related Tickets & Documents

Mobile & Desktop Screenshots/Recordings

Edit-Page-.Home.-.-WD_s-Revamp-.-WordPress.1.webm

Added tests?

  • 👍 yes
  • 🙅 no, because they aren't needed
  • 🙋 no, because I need help

Added to documentation?

  • 📜 README.md
  • 📓 Confluence
  • 🙅 no documentation needed

Others

  • 🦮 Is this issue accessible? (Section 508/WCAG 2.0AA)
  • 🙌 Does this issue pass all the linting? (PHPCS, ESLint, SassLint)

[optional] Are there any post-deployment tasks we need to perform?

@khleomix khleomix requested a review from itsamoreh July 28, 2023 20:18
@khleomix khleomix self-assigned this Jul 28, 2023
@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

@khleomix
Copy link
Contributor Author

khleomix commented Aug 7, 2023

Closing this out, was fixed by #35

@khleomix khleomix closed this Aug 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant