Feature/cc 409 admin dejquery #685
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…at refers to a "connection-settings-redirect" html class, I think this small part of the javascript is orphaned. On top of that, I checked out the 2.0.0 branch when it was first introduced, and still couldn't find any references to the class. Given the scope and size of the 2.0.0 release, I must conclude that the javascript spot was originally implemented at one time during the 2.0.0 release work, but a pivot was made and the js was missed for removal afterwards. I have tested the connection process without this snippet in the build files, and our workflow remained unaffected. If by chance we need to re-add in, after a release and support comes in, we most definitely can.
…arts for sake of jQuery Dialog
…. some jQuery required to remain due to jQuery events
|
If we run into build file issues, merge anyway and we can re-run npm scripts afterwards. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes MOST of the jQuery integration that we had with the admin side of our plugin interaction and functionality.
There are a couple spots that rely on CMB2 jQuery-based events that I had to leave in place with the builder.js file. If we decide long term to move away from CMB2, we can address at that time, but that is a much larger project than what we presently do.
There is also a spot using jQuery UI Dialog with the
modal.jsfile regarding log deletion confirmation that we're leaving as jQuery for the time being.Only the files in the
assets/js/ctct-plugin-admin/need to be reviewed, the others are build files, sourced from that folder.