Feature/cc 438 failed disconnect submission hardening #684
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…, and attempt to save the record
… this more direct and not dependent on logging in to see
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR amends our form display to still show list options regardless of detected connection status, and still allows attempt to submit a form entry to the API.
If the request fails, which should be the case for these changes, the entry attempt will be added to our logged attempts that will be re-attempted upon fresh connection status.
On top of that, to help hasten site admins re-establishing a connect, we will email the admin users any time that
log_missed_api_request()is triggered. This will more actively notify of issues, instead of potentially waiting weeks or longer before everything is processed.