Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/cc 440 comment login signup errors #683

Open
wants to merge 6 commits into
base: release270
Choose a base branch
from

Conversation

tw2113
Copy link
Member

@tw2113 tw2113 commented Sep 9, 2024

This PR protects against empty results for formatted list arrays.

It also touches up some list management in similar ways we do elsewhere for the plugin, as well as some logic touchups and invalid get_option usage.

* version bumps

* version bump and changelog

* Images cleanup (#676)

* old image removal

* remove old logo flare from "first form" modal

* another image removal

* update "first form" modal with new images

* remove reliance on meta data and instead rely on POST data for lists being used. (#680)

* remove reliance on meta data and instead rely on POST data for lists being used.

* add phpcs ignores for nonce things

* Update social icons in plugin list (#678)

* remove google plus which does not exist, remove twitter which does not seem to be working any more.

* re-add twitter as X, rename variables, add escaping to our site link value

* Fix/cc 434 optin js reveal (#679)

* fix optin display while also converting away from jQuery dependency

* build copies

* handle change events

* build files

* finish up changelog
@tw2113 tw2113 changed the base branch from main to release270 September 9, 2024 23:49
@tw2113
Copy link
Member Author

tw2113 commented Sep 9, 2024

@guzmandrade-wds Just look at includes/class-settings.php https://github.com/WebDevStudios/constant-contact-forms/pull/683/files#diff-ffe4c5eae4f71cfc06cca2fc4501f5eac2646795e3253f4b5d45c3efe226b592

The PR got mixed up a bit with a merge of main branch into release270 branch.

@tw2113 tw2113 added this to the 2.7.0 milestone Sep 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant