Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add auto-publish.yml #262

Merged
merged 2 commits into from
Jul 4, 2024
Merged

Conversation

mjwilson-google
Copy link
Contributor

This will add an auto-publish workflow to keep the working draft up to date, using spec-prod.

@svgeesus I don't have access to the secrets on the web-midi-api repository. Could you please do the following:

This should fix #258 once merged. Sorry this has taken such a long time.

@mjwilson-google
Copy link
Contributor Author

Looks like I also need to fix some markup.

@mjwilson-google mjwilson-google self-assigned this Jul 3, 2024
@mjwilson-google
Copy link
Contributor Author

Markup issue has been fixed.

@mjwilson-google mjwilson-google requested a review from hoch July 3, 2024 19:40
@mjwilson-google
Copy link
Contributor Author

Alternatively, @hoch are you able to check the repo secrets?

@hoch
Copy link
Member

hoch commented Jul 3, 2024

I haven't check the GitHub action for the Web MIDI spec. Have you confirmed/tested this PR on the current repo?

@mjwilson-google
Copy link
Contributor Author

Have you confirmed/tested this PR on the current repo?

It seems like the check is passing. I don't know how to check the auto-publish before merging. We need the Echinda secret though, otherwise it won't work, and I don't have permission to check the repo secrets.

@svgeesus
Copy link
Contributor

svgeesus commented Jul 4, 2024

We do already have a token for the Web MIDI API specification.

I added it, at WEB_MIDI_ECHIDNA

Copy link
Contributor

@svgeesus svgeesus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@svgeesus svgeesus merged commit c24c1ff into WebAudio:gh-pages Jul 4, 2024
1 check passed
@mjwilson-google mjwilson-google deleted the spec-prod branch July 6, 2024 06:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Publish updated Working Draft
3 participants