Explicitly set LIBCXXABI_USE_LLVM_UNWINDER off #377
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm baffled that this breaks things, considering OFF was the default before... |
|
Ok, it's broken even without the patch: https://github.com/glandium/wasi-sdk/actions/runs/7550972389/job/20557473630#logs |
|
Yeah, looks like a WASI signature change. I wonder if we should just pin Wasmtime for now or figure out how to recompile with the new signature. |
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Jan 18, 2024
…lding wasi-sdk. r=firefox-build-system-reviewers,sergesanspaille Clang trunk has recently turned it on, and also now fails the build when libunwind is not built at the same time. Upstreamed in WebAssembly/wasi-sdk#377 Differential Revision: https://phabricator.services.mozilla.com/D198763
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified-and-comments-removed
that referenced
this pull request
Jan 19, 2024
…lding wasi-sdk. r=firefox-build-system-reviewers,sergesanspaille Clang trunk has recently turned it on, and also now fails the build when libunwind is not built at the same time. Upstreamed in WebAssembly/wasi-sdk#377 Differential Revision: https://phabricator.services.mozilla.com/D198763 UltraBlame original commit: a4bff50d95674a402744d071f9d2b97b482452bb
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-comments-removed
that referenced
this pull request
Jan 19, 2024
…lding wasi-sdk. r=firefox-build-system-reviewers,sergesanspaille Clang trunk has recently turned it on, and also now fails the build when libunwind is not built at the same time. Upstreamed in WebAssembly/wasi-sdk#377 Differential Revision: https://phabricator.services.mozilla.com/D198763 UltraBlame original commit: a4bff50d95674a402744d071f9d2b97b482452bb
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified
that referenced
this pull request
Jan 19, 2024
…lding wasi-sdk. r=firefox-build-system-reviewers,sergesanspaille Clang trunk has recently turned it on, and also now fails the build when libunwind is not built at the same time. Upstreamed in WebAssembly/wasi-sdk#377 Differential Revision: https://phabricator.services.mozilla.com/D198763 UltraBlame original commit: a4bff50d95674a402744d071f9d2b97b482452bb
ErichDonGubler
pushed a commit
to erichdongubler-mozilla/firefox
that referenced
this pull request
Jan 19, 2024
…lding wasi-sdk. r=firefox-build-system-reviewers,sergesanspaille Clang trunk has recently turned it on, and also now fails the build when libunwind is not built at the same time. Upstreamed in WebAssembly/wasi-sdk#377 Differential Revision: https://phabricator.services.mozilla.com/D198763
I believe #382 fixes this so a rebase on top of that (once it merges) should fix the test failure. It's related to the ABI of the preview1-to-preview2 adapter that Wasmtime uses. |
Clang trunk has recently turned it on, and also now fails the build when libunwind is not built at the same time.
Merged
|
Merged in #393 |
freebsd-git
pushed a commit
to freebsd/freebsd-ports
that referenced
this pull request
Mar 27, 2024
LLVM 18 enables this by default, which is not wanted here. This is effectively a no-op for other LLVM versions. Context: WebAssembly/wasi-sdk#377
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clang trunk has recently turned it on, and also now fails the build when libunwind is not built at the same time.